Merge lp:~charlesk/indicator-display/lp-1377286-update-indicator-title-strings into lp:indicator-display/14.10

Proposed by Charles Kerr on 2014-10-03
Status: Merged
Approved by: Ted Gould on 2014-10-03
Approved revision: 7
Merged at revision: 7
Proposed branch: lp:~charlesk/indicator-display/lp-1377286-update-indicator-title-strings
Merge into: lp:indicator-display/14.10
Diff against target: 12 lines (+1/-1)
1 file modified
src/rotation-lock.cpp (+1/-1)
To merge this branch: bzr merge lp:~charlesk/indicator-display/lp-1377286-update-indicator-title-strings
Reviewer Review Type Date Requested Status
Ted Gould (community) 2014-10-03 Approve on 2014-10-03
Review via email: mp+237137@code.launchpad.net

Commit message

Change the phone header's title from "Rotation Lock" to "Rotation".

Description of the change

Change the phone header's title from "Rotation Lock" to "Rotation" as described in the "Indicators: RTM Usability Fixes" document.

Tested on mako + r68.

Note, this indicator can't yet be tested with ubuntu-system-settings, use the "gsettings set" method described in <http://bazaar.launchpad.net/~charlesk/indicator-display/lp-1377286-update-indicator-title-strings/view/head:/tests/manual>.

To post a comment you must log in.
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/rotation-lock.cpp'
2--- src/rotation-lock.cpp 2014-08-21 03:35:16 +0000
3+++ src/rotation-lock.cpp 2014-10-03 20:39:27 +0000
4@@ -141,7 +141,7 @@
5 void update_phone_header()
6 {
7 Header h;
8- h.title = _("Rotation lock");
9+ h.title = _("Rotation");
10 h.a11y = h.title;
11 h.is_visible = g_settings_get_enum(m_settings, "orientation-lock") != 0;
12 h.icon = m_icon;

Subscribers

People subscribed via source and target branches