Indicator Date and Time

Merge lp:~charlesk/indicator-datetime/unnecessary-saves into lp:indicator-datetime/12.10

  1. unnecessary-saves
  2. Merge into trunk.12.10
Proposed by Charles Kerr
Status: Merged
Approved by: Lars Karlitski
Approved revision: 177
Merged at revision: 177
Proposed branch: lp:~charlesk/indicator-datetime/unnecessary-saves
Merge into: lp:indicator-datetime/12.10
Diff against target: 20 lines (+7/-3)
1 file modified
src/datetime-prefs-locations.c (+7/-3)
To merge this branch: bzr merge lp:~charlesk/indicator-datetime/unnecessary-saves
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
Review via email: mp+106261@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Lars Karlitski (larsu) wrote :

Nice and simple.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/datetime-prefs-locations.c'
2--- src/datetime-prefs-locations.c 2012-04-18 21:19:13 +0000
3+++ src/datetime-prefs-locations.c 2012-05-17 21:07:20 +0000
4@@ -298,9 +298,13 @@
5 GDateTime * now_tz = g_date_time_to_timezone (now, tz);
6 gchar * format = generate_format_string_at_time (now_tz);
7 gchar * time_str = g_date_time_format (now_tz, format);
8-
9- gtk_list_store_set (store, &iter, COL_TIME, time_str, -1);
10-
11+ gchar * old_time_str;
12+
13+ gtk_tree_model_get (GTK_TREE_MODEL (store), &iter, COL_TIME, &old_time_str, -1);
14+ if (g_strcmp0 (old_time_str, time_str))
15+ gtk_list_store_set (store, &iter, COL_TIME, time_str, -1);
16+
17+ g_free (old_time_str);
18 g_free (time_str);
19 g_free (format);
20 g_date_time_unref (now_tz);

Subscribers

People subscribed via source and target branches