Merge lp:~charlesk/indicator-datetime/remove-g-type-init into lp:indicator-datetime/13.04

Proposed by Charles Kerr
Status: Merged
Merged at revision: 201
Proposed branch: lp:~charlesk/indicator-datetime/remove-g-type-init
Merge into: lp:indicator-datetime/13.04
Diff against target: 50 lines (+2/-5)
4 files modified
configure.ac (+1/-1)
debian/control (+1/-1)
src/datetime-service.c (+0/-2)
tests/test-indicator.cc (+0/-1)
To merge this branch: bzr merge lp:~charlesk/indicator-datetime/remove-g-type-init
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Mathieu Trudel-Lapierre Approve
Review via email: mp+143772@code.launchpad.net

Description of the change

remove g_type_init() calls and bump glib minimum to 2.35.4, where g_type_init() is deprecated

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approve.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote :

This was merged properly in a subsequent autolanding, not noted here by Jenkins: https://jenkins.qa.ubuntu.com/job/indicator-datetime-autolanding/27/ .

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2012-11-16 19:51:26 +0000
3+++ configure.ac 2013-01-17 21:21:21 +0000
4@@ -58,7 +58,7 @@
5 ICAL_REQUIRED_VERSION=0.48
6 CAIRO_REQUIRED_VERSION=1.10
7 GDK_REQUIRED_VERSION=2.22
8-GLIB_REQUIRED_VERSION=2.29.19
9+GLIB_REQUIRED_VERSION=2.35.4
10 GTK3_REQUIRED_VERSION=3.1.4
11
12 PKG_CHECK_MODULES(INDICATOR, indicator3-0.4 >= $INDICATOR_REQUIRED_VERSION
13
14=== modified file 'debian/control'
15--- debian/control 2012-11-16 21:51:29 +0000
16+++ debian/control 2013-01-17 21:21:21 +0000
17@@ -12,7 +12,7 @@
18 libindicator3-dev (>= 0.3.90),
19 libdbusmenu-glib-dev (>= 0.5.90),
20 libdbusmenu-gtk3-dev (>= 0.5.90),
21- libglib2.0-dev (>= 2.29.19),
22+ libglib2.0-dev (>= 2.35.4),
23 libido3-0.1-dev (>= 0.2.90),
24 libgeoclue-dev (>= 0.12.0),
25 libecal1.2-dev (>= 3.5),
26
27=== modified file 'src/datetime-service.c'
28--- src/datetime-service.c 2012-11-16 19:51:26 +0000
29+++ src/datetime-service.c 2013-01-17 21:21:21 +0000
30@@ -1401,8 +1401,6 @@
31 int
32 main (int argc, char ** argv)
33 {
34- g_type_init();
35-
36 /* Acknowledging the service init and setting up the interface */
37 service = indicator_service_new_version(SERVICE_NAME, SERVICE_VERSION);
38 g_signal_connect(service, INDICATOR_SERVICE_SIGNAL_SHUTDOWN, G_CALLBACK(service_shutdown), NULL);
39
40=== modified file 'tests/test-indicator.cc'
41--- tests/test-indicator.cc 2012-11-07 00:28:32 +0000
42+++ tests/test-indicator.cc 2013-01-17 21:21:21 +0000
43@@ -34,7 +34,6 @@
44 if (G_UNLIKELY(!initialized))
45 {
46 initialized = true;
47- g_type_init();
48 g_setenv ("GSETTINGS_SCHEMA_DIR", SCHEMA_DIR, TRUE);
49 }
50 }

Subscribers

People subscribed via source and target branches