Merge lp:~charlesk/indicator-datetime/lp-947315 into lp:indicator-datetime/0.4

Proposed by Charles Kerr
Status: Merged
Approved by: Charles Kerr
Approved revision: 169
Merge reported by: Charles Kerr
Merged at revision: not available
Proposed branch: lp:~charlesk/indicator-datetime/lp-947315
Merge into: lp:indicator-datetime/0.4
Diff against target: 26 lines (+1/-8)
1 file modified
src/datetime-prefs.c (+1/-8)
To merge this branch: bzr merge lp:~charlesk/indicator-datetime/lp-947315
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
Review via email: mp+100059@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

I know this is a low priority ticket, but this looks like a very easy fix...

Revision history for this message
Lars Karlitski (larsu) wrote :

Great catch with setting the dialog hint.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/datetime-prefs.c'
2--- src/datetime-prefs.c 2012-03-28 06:14:07 +0000
3+++ src/datetime-prefs.c 2012-03-30 00:40:24 +0000
4@@ -577,21 +577,14 @@
5 }
6
7 static void
8-hide_locations (IndicatorDatetimePanel * self)
9-{
10- if (self->priv->loc_dlg != NULL)
11- gtk_widget_destroy (self->priv->loc_dlg);
12-}
13-
14-static void
15 show_locations (IndicatorDatetimePanel * self)
16 {
17 if (self->priv->loc_dlg == NULL) {
18 self->priv->loc_dlg = datetime_setup_locations_dialog (self->priv->tzmap);
19 GtkWidget * dlg = gtk_widget_get_toplevel (GTK_WIDGET (self));
20+ gtk_window_set_type_hint (GTK_WINDOW(self->priv->loc_dlg), GDK_WINDOW_TYPE_HINT_DIALOG);
21 gtk_window_set_transient_for (GTK_WINDOW (self->priv->loc_dlg), GTK_WINDOW (dlg));
22 g_signal_connect (self->priv->loc_dlg, "destroy", G_CALLBACK (gtk_widget_destroyed), &self->priv->loc_dlg);
23- g_signal_connect_swapped (dlg, "focus-in-event", G_CALLBACK (hide_locations), self);
24 gtk_widget_show_all (self->priv->loc_dlg);
25 }
26 else {

Subscribers

People subscribed via source and target branches