Merge lp:~charlesk/indicator-datetime/lp-772340 into lp:indicator-datetime/0.4
Proposed by
Charles Kerr
Status: | Merged |
---|---|
Approved by: | Charles Kerr |
Approved revision: | 170 |
Merge reported by: | Charles Kerr |
Merged at revision: | not available |
Proposed branch: | lp:~charlesk/indicator-datetime/lp-772340 |
Merge into: | lp:indicator-datetime/0.4 |
Diff against target: |
268 lines (+65/-64) 1 file modified
src/datetime-service.c (+65/-64) |
To merge this branch: | bzr merge lp:~charlesk/indicator-datetime/lp-772340 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lars Karlitski (community) | Approve | ||
Review via email: mp+98469@code.launchpad.net |
To post a comment you must log in.
Great work, it's much cleaner now!
Two small comments:
* comp_instance_new:
- instead of putting it on two line, it's customary to do
ci->source = g_object_ref (comp);
* comp_instance_free:
- NULL check of 'ci' is missing