Merge lp:~charlesk/indicator-datetime/lp-1377286-update-indicator-title-strings into lp:indicator-datetime/13.10

Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 383
Merged at revision: 383
Proposed branch: lp:~charlesk/indicator-datetime/lp-1377286-update-indicator-title-strings
Merge into: lp:indicator-datetime/13.10
Diff against target: 25 lines (+2/-2)
2 files modified
src/menu.cpp (+1/-1)
tests/manual (+1/-1)
To merge this branch: bzr merge lp:~charlesk/indicator-datetime/lp-1377286-update-indicator-title-strings
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+237134@code.launchpad.net

Commit message

Change title to read "Time & Date"

Description of the change

== Description of Change

No behavioral changes, only one string change to make the title read "Time & Date" to match the "Indicators - RTM Usability Fixes" document.

==

> Are there any related MPs required for this MP to build/function as expected? Please list.

No

> Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)

Yes

> Did the code build without warnings?

Yes

> Did the tests run successfully?

Yes

> Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

> If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

> What device (or emulator) has your component test plan been executed successfully on?

mako + r68

> What manual tests are relevant for this MP?

indicator-datetime/unity8-items-check

> Did you include a link to the MR Review Checklist Template to make your reviewer's life easier?

https://wiki.ubuntu.com/Process/Merges/Checklists/indicator-datetime

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/menu.cpp'
2--- src/menu.cpp 2014-09-08 17:34:43 +0000
3+++ src/menu.cpp 2014-10-03 20:04:19 +0000
4@@ -516,7 +516,7 @@
5
6 GVariantBuilder b;
7 g_variant_builder_init(&b, G_VARIANT_TYPE_VARDICT);
8- g_variant_builder_add(&b, "{sv}", "title", g_variant_new_string (_("Upcoming events")));
9+ g_variant_builder_add(&b, "{sv}", "title", g_variant_new_string (_("Time & Date")));
10 g_variant_builder_add(&b, "{sv}", "visible", g_variant_new_boolean (TRUE));
11 if (has_alarms)
12 {
13
14=== modified file 'tests/manual'
15--- tests/manual 2014-09-16 20:21:47 +0000
16+++ tests/manual 2014-10-03 20:04:19 +0000
17@@ -17,7 +17,7 @@
18 <dl>
19 <dt>Login to a user session running Unity 8</dt>
20 <dt>Pull down the top panel until it sticks open</dt>
21- <dt>Navigate through the tabs until "Upcoming events" is shown</dt>
22+ <dt>Navigate through the tabs until "Time & Date" is shown</dt>
23 <dd>Upcoming is at the top of the menu</dd>
24 <dd>The menu is populated with items</dd>
25 </dl>

Subscribers

People subscribed via source and target branches