Merge lp:~charlesk/indicator-datetime/lp-1364949-honor-changes-to-alarm-sounds into lp:indicator-datetime/13.10

[Charles Kerr]

Fix appointment comparison function to include the audio_url field in its test.

1. Fix appointment comparison function to include the audio_url field in its test. Missing this is what prevented the core::Property's changed signals from being emitted -- Appointment's equality operator reported two appointments as the same even when they had different audio_url fields.

2. Added manual test based on Dave Morley's report in bug #1364949

[Antti Kaijanmäki (kaijanmaki)]

LGTM.

review: Approve

=== modified file 'src/appointment.cpp'
--- src/appointment.cpp	2014-04-15 14:50:07 +0000
+++ src/appointment.cpp	2014-10-07 18:48:12 +0000
@@ -32,6 +32,7 @@
     return (color==that.color)
         && (summary==that.summary)
         && (url==that.url)
+        && (audio_url==that.audio_url)
         && (uid==that.uid)
         && (has_alarms==that.has_alarms)
         && (begin==that.begin)

=== modified file 'tests/manual'
--- tests/manual	2014-09-16 20:21:47 +0000
+++ tests/manual	2014-10-07 18:48:12 +0000
@@ -79,6 +79,19 @@
 		<dd>Sound should stop at the same time, rather than playing til the end of the file.</dd>
 </dl>
 
+Test-case indicator-datetime/change-alarm-sound
+<dl>
+	<dt>Open the clock app</dt>
+	<dt>Swipe up from the bottom</dt>
+	<dt>Click on the + symbol</dt>
+	<dt>Save an alarm for a few minutes time leave everything on default settings</dt>
+	<dt>Click on save</dt>
+	<dt>Click on the alarm</dt>
+	<dt>Change the sound of the alarm</dt>
+	<dt>Click on save</dt>
+	<dt>Let the alarm go off</dt>
+		<dd>The newly-selected sound should play, rather than the previous sound.</dd>
+</dl>
 
 <strong>
     If all actions produce the expected results listed, please <a href="results#add_result">submit</a> a 'passed' result.