lp:~charlesk/indicator-datetime/lp-1318997-export-properties-to-dbus

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:indicator-datetime/13.10 at revision 351

PS Jenkins bot (community): Approve (continuous-integration) on 2014-06-27

Ted Gould (community): Approve on 2014-06-27

Diff: 1320 lines (+550/-309)

19 files modified

MERGE-REVIEW (+30/-39)
data/CMakeLists.txt (+8/-2)
data/com.canonical.indicator.datetime.AlarmProperties.xml (+31/-0)
data/com.canonical.indicator.datetime.gschema.xml.in (+55/-61)
include/datetime/exporter.h (+9/-20)
include/datetime/settings-shared.h (+0/-10)
include/datetime/settings.h (+2/-2)
src/CMakeLists.txt (+24/-7)
src/engine-eds.cpp (+2/-4)
src/exporter.cpp (+212/-95)
src/main.cpp (+2/-2)
src/settings-live.cpp (+6/-6)
src/snap.cpp (+17/-20)
tests/CMakeLists.txt (+4/-2)
tests/manual (+22/-0)
tests/manual-test-snap.cpp (+21/-1)
tests/test-exporter.cpp (+93/-2)
tests/test-menus.cpp (+1/-1)
tests/test-settings.cpp (+11/-35)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1318997: [clock] Provide a way to change alarm sound

High

Fix Released

Link a bug report

Related blueprints

366. By Charles Kerr on 2014-06-30

Format the manual tests properly. Update the submitter/reviewer checklist.

365. By Charles Kerr on 2014-06-27

use unsigned ints for the alarm volume, duration properties

364. By Charles Kerr on 2014-06-27

use intltool-merge to generate com.canonical.indicator.datetime.gschema.xml

363. By Charles Kerr on 2014-06-27

Design prefers to have a volume slider instead of presets, so remove the AlarmVolume enum and replace it with an int range.

362. By Charles Kerr on 2014-06-27

Expose the alarm settings via dbus properties.

361. By Charles Kerr on 2014-06-27

fix test-menus.cpp build failure in clang++

360. By Charles Kerr on 2014-06-27

fix clang++ warning about unused private field in snap.cpp's Sound class

359. By Charles Kerr on 2014-06-27

fix clang++ warning about an unused private field in EdsEngine

358. By Charles Kerr on 2014-06-26

Add Exporter's implementation to an Impl file because I'm about to shovel more methods and fields in there.

357. By Charles Kerr on 2014-06-25

make get_gain_level() a little easier to read.