Merge lp:~charlesk/indicator-datetime/lp-1251460 into lp:indicator-datetime/14.04

Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 287
Merged at revision: 288
Proposed branch: lp:~charlesk/indicator-datetime/lp-1251460
Merge into: lp:indicator-datetime/14.04
Diff against target: 15 lines (+2/-3)
1 file modified
src/clock-live.c (+2/-3)
To merge this branch: bzr merge lp:~charlesk/indicator-datetime/lp-1251460
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ted Gould (community) Approve
Review via email: mp+195321@code.launchpad.net

Commit message

In src/clock-live.c, pass the right pointer to on_detect_location_changed().

Description of the change

clock-live.c has a private function with this signature:

> static void on_detect_location_changed (IndicatorDatetimeClockLive * self)

and indicator_datetime_clock_live_init() has this code:

> g_signal_connect (p->settings, "changed::" SETTINGS_SHOW_DETECTED_S,
> G_CALLBACK(on_detect_location_changed), self);

This should be _connect_swapped() s.t. self is passed to on_detect_location_changed().

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/clock-live.c'
2--- src/clock-live.c 2013-10-24 21:47:08 +0000
3+++ src/clock-live.c 2013-11-14 22:54:10 +0000
4@@ -259,9 +259,8 @@
5 self->priv = p;
6
7 p->settings = g_settings_new (SETTINGS_INTERFACE);
8- g_signal_connect (p->settings, "changed::" SETTINGS_SHOW_DETECTED_S,
9- G_CALLBACK(on_detect_location_changed), self);
10-
11+ g_signal_connect_swapped (p->settings, "changed::" SETTINGS_SHOW_DETECTED_S,
12+ G_CALLBACK(on_detect_location_changed), self);
13
14 on_detect_location_changed (self);
15 }

Subscribers

People subscribed via source and target branches