Code review comment for lp:~charlesk/indicator-datetime/lp-1246812

Revision history for this message
Lars Karlitski (larsu) wrote :

Ok.

There's something in here I don't like, but it's not related to this patch: the icon name is set without using g_icon_serialize(). That's fine in practice though, as an icon name is serialized to a string with that icon name. While it's not specified to do so and might change, I see little reason that that ever will.

review: Approve

« Back to merge proposal