Code review comment for lp:~charlesk/indicator-datetime/lp-1233176

Revision history for this message
Ted Gould (ted) wrote :

I'm worried a bit about the alarm implementation, it seems like just checking for alarms every minute is a not as eloquent as we can be. We know when the next alarm is, we should wait that amount of time.

I haven't seen the final designs here, but I'm a bit surprised that we're launching the app when the alarm goes off. This will cause a focus change. Which means that you can potentially have your work interrupted by an alarm. It seems to me that there should be a notification with the option to ignore or open the URL.

review: Needs Information

« Back to merge proposal