Merge lp:~charlesk/indicator-datetime/fix-flint++-warnings into lp:indicator-datetime/13.10

[Charles Kerr]

Fix flint++ warnings

Keeping a promise to Satoris from when he reviewed/approved another datetime MP -- this MP fixes a batch of flint++ warnings reported against indicator-datetime:

 * classes with virtual functions but non-virtual dtors
 * single-argument constructors that should use the explicit keyword
 * missing #include guards
 * use of NULL instead of nullptr in c++11 code
 * prefer std::make_shared<> when possible

There are still a handful of warnings left, either invalid (e.g., suggesting make_shared for a shared_ptr that's got a custom deleter) and a couple of others that are resolved as side-effects of the other indicator-datetime MPs already floating around today.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:378
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/279/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-utopic-amd64-ci/53
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-utopic-armhf-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-utopic-armhf-ci/53/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/279/rebuild

review: Approve (continuous-integration)

[Ted Gould (ted)]

Have a hard time getting excited about these, but they look fine.

review: Approve

=== modified file 'include/datetime/actions-live.h'
--- include/datetime/actions-live.h	2014-03-22 07:25:50 +0000
+++ include/datetime/actions-live.h	2014-09-17 16:59:23 +0000
@@ -36,21 +36,21 @@
 class LiveActions: public Actions
 {
 public:
-    LiveActions(const std::shared_ptr<State>& state_in);
-    ~LiveActions() =default;
-
-    bool desktop_has_calendar_app() const;
-    void desktop_open_alarm_app();
-    void desktop_open_appointment(const Appointment&);
-    void desktop_open_calendar_app(const DateTime&);
-    void desktop_open_settings_app();
-
-    void phone_open_alarm_app();
-    void phone_open_appointment(const Appointment&);
-    void phone_open_calendar_app(const DateTime&);
-    void phone_open_settings_app();
-
-    void set_location(const std::string& zone, const std::string& name);
+    explicit LiveActions(const std::shared_ptr<State>& state_in);
+    virtual ~LiveActions() =default;
+
+    bool desktop_has_calendar_app() const override;
+    void desktop_open_alarm_app() override;
+    void desktop_open_appointment(const Appointment&) override;
+    void desktop_open_calendar_app(const DateTime&) override;
+    void desktop_open_settings_app() override;
+
+    void phone_open_alarm_app() override;
+    void phone_open_appointment(const Appointment&) override;
+    void phone_open_calendar_app(const DateTime&) override;
+    void phone_open_settings_app() override;
+
+    void set_location(const std::string& zone, const std::string& name) override;
 
 protected:
     virtual void execute_command(const std::string& command);
 
=== modified file 'include/datetime/actions.h'
--- include/datetime/actions.h	2014-03-22 07:25:50 +0000
+++ include/datetime/actions.h	2014-09-17 16:59:23 +0000
@@ -61,7 +61,7 @@
     const std::shared_ptr<State> state() const;
 
 protected:
-    Actions(const std::shared_ptr<State>& state);
+    explicit Actions(const std::shared_ptr<State>& state);
     virtual ~Actions();
 
 private:
 
=== modified file 'include/datetime/clock-mock.h'
--- include/datetime/clock-mock.h	2014-09-15 19:49:20 +0000
+++ include/datetime/clock-mock.h	2014-09-17 16:59:23 +0000
@@ -36,7 +36,7 @@
 class MockClock: public Clock
 {
 public:
-    MockClock(const DateTime& dt): m_localtime(dt) {}
+    explicit MockClock(const DateTime& dt): m_localtime(dt) {}
     ~MockClock() =default;
 
     DateTime localtime() const { return m_localtime; }
 
=== modified file 'include/datetime/dbus-shared.h'
--- include/datetime/dbus-shared.h	2014-09-13 18:39:19 +0000
+++ include/datetime/dbus-shared.h	2014-09-17 16:59:23 +0000
@@ -18,8 +18,8 @@
  *   Charles Kerr <[e-mail]>
  */
 
-#ifndef _INDICATOR_DATETIME_DBUS_SHARED_H_
-#define _INDICATOR_DATETIME_DBUS_SHARED_H_
+#ifndef INDICATOR_DATETIME_DBUS_SHARED_H
+#define INDICATOR_DATETIME_DBUS_SHARED_H
 
 #define BUS_DATETIME_NAME    "com.canonical.indicator.datetime"
 #define BUS_DATETIME_PATH    "/com/canonical/indicator/datetime"
@@ -29,4 +29,4 @@
 #define BUS_POWERD_INTERFACE "com.canonical.powerd"
 
 
-#endif /* _INDICATOR_DATETIME_DBUS_SHARED_H_ */
+#endif /* INDICATOR_DATETIME_DBUS_SHARED_H */
 
=== modified file 'include/datetime/engine-eds.h'
--- include/datetime/engine-eds.h	2014-03-10 03:26:26 +0000
+++ include/datetime/engine-eds.h	2014-09-17 16:59:23 +0000
@@ -17,8 +17,8 @@
  *   Charles Kerr <[e-mail]>
  */
 
-#ifndef INDICATOR_DATETIME_ENGINE_EDS__H
-#define INDICATOR_DATETIME_ENGINE_EDS__H
+#ifndef INDICATOR_DATETIME_ENGINE_EDS_H
+#define INDICATOR_DATETIME_ENGINE_EDS_H
 
 #include <datetime/engine.h>
 
@@ -72,4 +72,4 @@
 } // namespace indicator
 } // namespace unity
 
-#endif // INDICATOR_DATETIME_ENGINE_EDS__H
+#endif // INDICATOR_DATETIME_ENGINE_EDS_H
 
=== modified file 'include/datetime/engine-mock.h'
--- include/datetime/engine-mock.h	2014-03-10 03:26:26 +0000
+++ include/datetime/engine-mock.h	2014-09-17 16:59:23 +0000
@@ -17,8 +17,8 @@
  *   Charles Kerr <[e-mail]>
  */
 
-#ifndef INDICATOR_DATETIME_ENGINE_MOCK__H
-#define INDICATOR_DATETIME_ENGINE_MOCK__H
+#ifndef INDICATOR_DATETIME_ENGINE_MOCK_H
+#define INDICATOR_DATETIME_ENGINE_MOCK_H
 
 #include <datetime/engine.h>
 
@@ -65,4 +65,4 @@
 } // namespace indicator
 } // namespace unity
 
-#endif // INDICATOR_DATETIME_ENGINE_NOOP__H
+#endif // INDICATOR_DATETIME_ENGINE_MOCK_H
 
=== modified file 'include/datetime/engine.h'
--- include/datetime/engine.h	2014-03-10 03:26:26 +0000
+++ include/datetime/engine.h	2014-09-17 16:59:23 +0000
@@ -17,8 +17,8 @@
  *   Charles Kerr <[e-mail]>
  */
 
-#ifndef INDICATOR_DATETIME_ENGINE__H
-#define INDICATOR_DATETIME_ENGINE__H
+#ifndef INDICATOR_DATETIME_ENGINE_H
+#define INDICATOR_DATETIME_ENGINE_H
 
 #include <datetime/appointment.h>
 #include <datetime/date-time.h>
@@ -65,4 +65,4 @@
 } // namespace indicator
 } // namespace unity
 
-#endif // INDICATOR_DATETIME_ENGINE__H
+#endif // INDICATOR_DATETIME_ENGINE_H
 
=== modified file 'include/datetime/exporter.h'
--- include/datetime/exporter.h	2014-06-27 02:36:42 +0000
+++ include/datetime/exporter.h	2014-09-17 16:59:23 +0000
@@ -39,7 +39,7 @@
 class Exporter
 {
 public:
-    Exporter(const std::shared_ptr<Settings>&);
+    explicit Exporter(const std::shared_ptr<Settings>&);
     ~Exporter();
 
     core::Signal<>& name_lost();
 
=== modified file 'include/datetime/formatter.h'
--- include/datetime/formatter.h	2014-01-31 00:33:14 +0000
+++ include/datetime/formatter.h	2014-09-17 16:59:23 +0000
@@ -86,7 +86,7 @@
     std::string relative_format(GDateTime* then, GDateTime* then_end=nullptr) const;
 
 protected:
-    Formatter(const std::shared_ptr<const Clock>&);
+    explicit Formatter(const std::shared_ptr<const Clock>&);
     virtual ~Formatter();
 
     static const char* default_header_time_format(bool twelvehour, bool show_seconds);
@@ -126,7 +126,7 @@
 class PhoneFormatter: public Formatter
 {
 public:
-    PhoneFormatter(const std::shared_ptr<const Clock>& clock): Formatter(clock) {
+    explicit PhoneFormatter(const std::shared_ptr<const Clock>& clock): Formatter(clock) {
         header_format.set(default_header_time_format(is_locale_12h(), false));
     }
 };
 
=== modified file 'include/datetime/planner-range.h'
--- include/datetime/planner-range.h	2014-04-25 03:34:42 +0000
+++ include/datetime/planner-range.h	2014-09-17 16:59:23 +0000
@@ -72,7 +72,7 @@
     core::Property<std::vector<Appointment>> m_appointments;
 
     // we've got a GSignal tag here, so disable copying
-    SimpleRangePlanner(const RangePlanner&) =delete;
+    explicit SimpleRangePlanner(const RangePlanner&) =delete;
     SimpleRangePlanner& operator=(const RangePlanner&) =delete;
 };
 
 
=== modified file 'include/datetime/wakeup-timer-mainloop.h'
--- include/datetime/wakeup-timer-mainloop.h	2014-04-25 03:34:42 +0000
+++ include/datetime/wakeup-timer-mainloop.h	2014-09-17 16:59:23 +0000
@@ -39,7 +39,7 @@
 class MainloopWakeupTimer: public WakeupTimer
 {
 public:
-    MainloopWakeupTimer(const std::shared_ptr<Clock>&);
+    explicit MainloopWakeupTimer(const std::shared_ptr<Clock>&);
     ~MainloopWakeupTimer();
     void set_wakeup_time (const DateTime&);
     core::Signal<>& timeout();
 
=== modified file 'include/datetime/wakeup-timer-powerd.h'
--- include/datetime/wakeup-timer-powerd.h	2014-08-19 04:03:38 +0000
+++ include/datetime/wakeup-timer-powerd.h	2014-09-17 16:59:23 +0000
@@ -39,7 +39,7 @@
 class PowerdWakeupTimer: public WakeupTimer
 {
 public:
-    PowerdWakeupTimer(const std::shared_ptr<Clock>&);
+    explicit PowerdWakeupTimer(const std::shared_ptr<Clock>&);
     ~PowerdWakeupTimer();
     void set_wakeup_time(const DateTime&);
     core::Signal<>& timeout();
 
=== modified file 'include/notifications/awake.h'
--- include/notifications/awake.h	2014-07-27 04:35:38 +0000
+++ include/notifications/awake.h	2014-09-17 16:59:23 +0000
@@ -36,7 +36,7 @@
 class Awake
 {
 public:
-    Awake(const std::string& app_name);
+    explicit Awake(const std::string& app_name);
     ~Awake();
 
 private:
 
=== modified file 'include/notifications/haptic.h'
--- include/notifications/haptic.h	2014-08-01 00:52:42 +0000
+++ include/notifications/haptic.h	2014-09-17 16:59:23 +0000
@@ -41,7 +41,7 @@
       MODE_PULSE
     };
 
-    Haptic(const Mode& mode = MODE_PULSE);
+    explicit Haptic(const Mode& mode = MODE_PULSE);
     ~Haptic();
 
 private:
 
=== modified file 'include/notifications/notifications.h'
--- include/notifications/notifications.h	2014-07-30 22:59:52 +0000
+++ include/notifications/notifications.h	2014-09-17 16:59:23 +0000
@@ -85,7 +85,7 @@
 class Engine
 {
 public:
-    Engine(const std::string& app_name);
+    explicit Engine(const std::string& app_name);
     ~Engine();
 
     /** @see Builder::set_action() */
 
=== modified file 'src/engine-eds.cpp'
--- src/engine-eds.cpp	2014-06-27 01:46:06 +0000
+++ src/engine-eds.cpp	2014-09-17 16:59:23 +0000
@@ -285,7 +285,7 @@
         if (e_cal_client_get_view_finish (E_CAL_CLIENT(client), res, &view, &error))
         {
             // add the view to our collection
-            e_cal_client_view_set_flags(view, E_CAL_CLIENT_VIEW_FLAGS_NONE, NULL);
+            e_cal_client_view_set_flags(view, E_CAL_CLIENT_VIEW_FLAGS_NONE, nullptr);
             e_cal_client_view_start(view, &error);
             g_debug("got a view for %s", e_cal_client_get_local_attachment_store(E_CAL_CLIENT(client)));
             auto self = static_cast<Impl*>(gself);
 
=== modified file 'src/planner-snooze.cpp'
--- src/planner-snooze.cpp	2014-09-03 04:44:00 +0000
+++ src/planner-snooze.cpp	2014-09-17 16:59:23 +0000
@@ -46,7 +46,7 @@
     {
     }
 
-    virtual core::Property<std::vector<Appointment>>& appointments()
+    core::Property<std::vector<Appointment>>& appointments()
     {
         return m_appointments;
     }
 
=== modified file 'src/sound.cpp'
--- src/sound.cpp	2014-09-04 21:57:14 +0000
+++ src/sound.cpp	2014-09-17 16:59:23 +0000
@@ -113,17 +113,17 @@
         else if ((GST_MESSAGE_TYPE(msg) == GST_MESSAGE_STREAM_START) && (self->m_loop))
         {
             /* Set the media role if audio sink is pulsesink */
-            GstElement *audio_sink = NULL;
-            g_object_get(self->m_play, "audio-sink", &audio_sink, NULL);
+            GstElement *audio_sink = nullptr;
+            g_object_get(self->m_play, "audio-sink", &audio_sink, nullptr);
             if (audio_sink)
             {
-                GstPluginFeature *feature = NULL;
+                GstPluginFeature *feature = nullptr;
                 feature = GST_PLUGIN_FEATURE_CAST(GST_ELEMENT_GET_CLASS(audio_sink)->elementfactory);
                 if (feature && g_strcmp0(gst_plugin_feature_get_name(feature), "pulsesink") == 0)
                 {
                     std::string role_str("props,media.role=alarm");
-                    GstStructure *props = gst_structure_from_string(role_str.c_str(), NULL);
-                    g_object_set(audio_sink, "stream-properties", props, NULL);
+                    GstStructure *props = gst_structure_from_string(role_str.c_str(), nullptr);
+                    g_object_set(audio_sink, "stream-properties", props, nullptr);
                     gst_structure_free(props);
                 }
                 gst_object_unref(audio_sink);
 
=== modified file 'src/wakeup-timer-powerd.cpp'
--- src/wakeup-timer-powerd.cpp	2014-08-19 04:08:38 +0000
+++ src/wakeup-timer-powerd.cpp	2014-09-17 16:59:23 +0000
@@ -195,7 +195,7 @@
         }
         else
         {
-            const char* s = NULL;
+            const char* s = nullptr;
             g_variant_get(ret, "(&s)", &s);
             g_debug("%s %s::requestWakeup() sent cookie %s",
                     G_STRLOC, BUS_POWERD_NAME, s);
 
=== modified file 'tests/actions-mock.h'
--- tests/actions-mock.h	2014-03-22 07:25:50 +0000
+++ tests/actions-mock.h	2014-09-17 16:59:23 +0000
@@ -31,7 +31,7 @@
 class MockActions: public Actions
 {
 public:
-    MockActions(std::shared_ptr<State>& state_in): Actions(state_in) {}
+    explicit MockActions(const std::shared_ptr<State>& state_in): Actions(state_in) {}
     ~MockActions() =default;
 
     enum Action { DesktopOpenAlarmApp,
 
=== modified file 'tests/geoclue-fixture.h'
--- tests/geoclue-fixture.h	2014-02-02 21:29:29 +0000
+++ tests/geoclue-fixture.h	2014-09-17 16:59:23 +0000
@@ -17,6 +17,9 @@
  * with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#ifndef INDICATOR_DATETIME_TESTS_GEOCLUE_FIXTURE_H
+#define INDICATOR_DATETIME_TESTS_GEOCLUE_FIXTURE_H
+
 #include "glib-fixture.h"
 
 #include <libdbustest/dbus-test.h>
@@ -39,7 +42,7 @@
     DbusTestDbusMockObject * obj_geo_addr = nullptr;
     const std::string timezone_1 = "America/Denver";
 
-    void SetUp ()
+    void SetUp () override
     {
       super::SetUp();
 
@@ -80,7 +83,7 @@
       g_string_free (gstr, TRUE);
     }
 
-    virtual void TearDown ()
+    void TearDown () override
     {
       g_clear_object (&mock);
       g_clear_object (&service);
@@ -148,3 +151,4 @@
 
 };
 
+#endif /* INDICATOR_DATETIME_TESTS_GEOCLUE_FIXTURE_H */
 
=== modified file 'tests/glib-fixture.h'
--- tests/glib-fixture.h	2014-01-29 03:15:39 +0000
+++ tests/glib-fixture.h	2014-09-17 16:59:23 +0000
@@ -17,6 +17,9 @@
  * with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#ifndef INDICATOR_DATETIME_TESTS_GLIB_FIXTURE_H
+#define INDICATOR_DATETIME_TESTS_GLIB_FIXTURE_H
+
 #include <map>
 
 #include <glib.h>
@@ -29,6 +32,10 @@
 
 class GlibFixture : public ::testing::Test
 {
+  public:
+
+    virtual ~GlibFixture() =default;
+
   private:
 
     //GLogFunc realLogHandler;
@@ -59,7 +66,7 @@
 
   protected:
 
-    virtual void SetUp()
+    virtual void SetUp() override
     {
       setlocale(LC_ALL, "C.UTF-8");
 
@@ -76,7 +83,7 @@
 
     }
 
-    virtual void TearDown()
+    virtual void TearDown() override
     {
 #if 0
       // confirm there aren't any unexpected log messages
@@ -136,3 +143,5 @@
 
     GMainLoop * loop;
 };
+
+#endif /* INDICATOR_DATETIME_TESTS_GLIB_FIXTURE_H */
 
=== modified file 'tests/manual-test-snap.cpp'
--- tests/manual-test-snap.cpp	2014-09-03 04:22:04 +0000
+++ tests/manual-test-snap.cpp	2014-09-17 16:59:23 +0000
@@ -47,7 +47,7 @@
     GOptionEntry entries[] =
     {
         { "volume", 'v', 0, G_OPTION_ARG_INT, &volume, "Volume level [1..100]", "volume" },
-        { NULL }
+        { nullptr }
     };
 }
 
 
=== modified file 'tests/state-fixture.h'
--- tests/state-fixture.h	2014-01-22 05:27:45 +0000
+++ tests/state-fixture.h	2014-09-17 16:59:23 +0000
@@ -17,18 +17,30 @@
  *   Charles Kerr <[e-mail]>
  */
 
+#ifndef INDICATOR_DATETIME_TESTS_STATE_FIXTURE_H
+#define INDICATOR_DATETIME_TESTS_STATE_FIXTURE_H
+
 #include "glib-fixture.h"
 
 #include "actions-mock.h"
 #include "state-mock.h"
 
-using namespace unity::indicator::datetime;
+namespace unity {
+namespace indicator {
+namespace datetime {
+
+/***
+****
+***/
 
 class StateFixture: public GlibFixture
 {
 private:
     typedef GlibFixture super;
 
+public:
+    virtual ~StateFixture() =default;
+
 protected:
     std::shared_ptr<MockState> m_mock_state;
     std::shared_ptr<State> m_state;
@@ -56,5 +68,15 @@
 
         super::TearDown();
     }
+
 };
 
+/***
+****
+***/
+
+} // namespace datetime
+} // namespace indicator
+} // namespace unity
+
+#endif /* INDICATOR_DATETIME_TESTS_STATE_FIXTURE_H */
 
=== modified file 'tests/state-mock.h'
--- tests/state-mock.h	2014-03-10 02:08:47 +0000
+++ tests/state-mock.h	2014-09-17 16:59:23 +0000
@@ -17,12 +17,21 @@
  *   Charles Kerr <[e-mail]>
  */
 
+#ifndef INDICATOR_DATETIME_STATE_MOCK_H
+#define INDICATOR_DATETIME_STATE_MOCK_H
+
 #include "planner-mock.h"
 
 #include <datetime/clock-mock.h>
 #include <datetime/state.h>
 
-using namespace unity::indicator::datetime;
+namespace unity {
+namespace indicator {
+namespace datetime {
+
+/***
+****
+***/
 
 class MockState: public State
 {
@@ -47,3 +56,12 @@
     }
 };
 
+/***
+****
+***/
+
+} // namespace datetime
+} // namespace indicator
+} // namespace unity
+
+#endif /* INDICATOR_DATETIME_STATE_MOCK_H */
 
=== modified file 'tests/test-actions.cpp'
--- tests/test-actions.cpp	2014-03-24 16:18:12 +0000
+++ tests/test-actions.cpp	2014-09-17 16:59:23 +0000
@@ -55,12 +55,12 @@
 
 protected:
 
-    virtual void SetUp()
+    void SetUp() override
     {
         super::SetUp();
     }
 
-    virtual void TearDown()
+    void TearDown() override
     {
         super::TearDown();
     }
 
=== modified file 'tests/test-dbus-fixture.h'
--- tests/test-dbus-fixture.h	2014-01-17 03:23:57 +0000
+++ tests/test-dbus-fixture.h	2014-09-17 16:59:23 +0000
@@ -17,6 +17,9 @@
  *   Charles Kerr <[e-mail]>
  */
 
+#ifndef INDICATOR_DATETIME_TESTS_DBUS_FIXTURE_H
+#define INDICATOR_DATETIME_TESTS_DBUS_FIXTURE_H
+
 #include "glib-fixture.h"
 
 /***
@@ -27,9 +30,10 @@
 {
   public:
 
-    TestDBusFixture() {}
+    TestDBusFixture() =default;
+    virtual ~TestDBusFixture() =default;
 
-    TestDBusFixture(const std::vector<std::string>& service_dirs_in): service_dirs(service_dirs_in) {}
+    explicit TestDBusFixture(const std::vector<std::string>& service_dirs_in): service_dirs(service_dirs_in) {}
 
   private:
 
@@ -65,7 +69,7 @@
     GDBusConnection * system_bus;
     const std::vector<std::string> service_dirs;
 
-    virtual void SetUp ()
+    virtual void SetUp() override
     {
       super::SetUp ();
 
@@ -84,7 +88,7 @@
       g_main_loop_run (loop);
     }
 
-    virtual void TearDown ()
+    virtual void TearDown() override
     {
       wait_msec();
 
@@ -100,3 +104,5 @@
       super::TearDown();
     }
 };
+
+#endif /* INDICATOR_DATETIME_TESTS_DBUS_FIXTURE_H */
 
=== modified file 'tests/test-exporter.cpp'
--- tests/test-exporter.cpp	2014-09-02 15:37:03 +0000
+++ tests/test-exporter.cpp	2014-09-17 16:59:23 +0000
@@ -42,7 +42,7 @@
 
     GTestDBus* bus = nullptr;
 
-    void SetUp()
+    void SetUp() override
     {
         super::SetUp();
 
@@ -54,7 +54,7 @@
         g_setenv("DBUS_SESSION_BUS_ADDRESS", address, true);
     }
 
-    void TearDown()
+    void TearDown() override
     {
         GError * error = nullptr;
         GDBusConnection* connection = g_bus_get_sync(G_BUS_TYPE_SESSION, nullptr, &error);
@@ -76,9 +76,9 @@
 
 TEST_F(ExporterFixture, Publish)
 {
-    std::shared_ptr<State> state(new MockState);
-    std::shared_ptr<Actions> actions(new MockActions(state));
-    std::shared_ptr<Settings> settings(new Settings);
+    auto state = std::make_shared<MockState>();
+    auto actions = std::make_shared<MockActions>(state);
+    auto settings = std::make_shared<Settings>();
     std::vector<std::shared_ptr<Menu>> menus;
 
     MenuFactory menu_factory (actions, state);
 
=== modified file 'tests/test-formatter.cpp'
--- tests/test-formatter.cpp	2014-01-31 00:33:14 +0000
+++ tests/test-formatter.cpp	2014-09-17 16:59:23 +0000
@@ -46,7 +46,7 @@
 
     std::shared_ptr<Settings> m_settings;
 
-    virtual void SetUp()
+    void SetUp() override
     {
       super::SetUp();
 
@@ -54,7 +54,7 @@
       m_original_locale = g_strdup(setlocale(LC_TIME, nullptr));
     }
 
-    virtual void TearDown()
+    void TearDown() override
     {
       m_settings.reset();
 
@@ -90,7 +90,7 @@
 TEST_F(FormatterFixture, TestPhoneHeader)
 {
     auto now = g_date_time_new_local(2020, 10, 31, 18, 30, 59);
-    std::shared_ptr<Clock> clock(new MockClock(DateTime(now)));
+    auto clock = std::make_shared<MockClock>(DateTime(now));
     g_date_time_unref(now);
 
     // test the default value in a 24h locale
@@ -143,7 +143,7 @@
   };
 
   auto now = g_date_time_new_local(2020, 10, 31, 18, 30, 59);
-  std::shared_ptr<Clock> clock(new MockClock(DateTime(now)));
+  auto clock = std::make_shared<MockClock>(DateTime(now));
   g_date_time_unref(now);
 
   for(const auto& test_case : test_cases)
@@ -193,7 +193,7 @@
     {
         if (test_case.is_12h ? Set12hLocale() : Set24hLocale())
         {
-            std::shared_ptr<Clock> clock (new MockClock(DateTime(test_case.now)));
+            auto clock = std::make_shared<MockClock>(DateTime(test_case.now));
             DesktopFormatter f(clock, m_settings);
         
             const auto fmt = f.relative_format(test_case.then);
@@ -236,7 +236,7 @@
     {
         if (test_case.is_12h ? Set12hLocale() : Set24hLocale())
         {
-            std::shared_ptr<Clock> clock(new MockClock(DateTime(test_case.now)));
+            auto clock = std::make_shared<MockClock>(DateTime(test_case.now));
             DesktopFormatter f(clock, m_settings);
           
             const auto fmt = f.relative_format(test_case.then, test_case.then_end);
 
=== modified file 'tests/test-live-actions.cpp'
--- tests/test-live-actions.cpp	2014-03-22 07:25:50 +0000
+++ tests/test-live-actions.cpp	2014-09-17 16:59:23 +0000
@@ -26,17 +26,19 @@
 ****
 ***/
 
+using namespace unity::indicator::datetime;
+
 class MockLiveActions: public LiveActions
 {
 public:
     std::string last_cmd;
     std::string last_url;
-    MockLiveActions(const std::shared_ptr<State>& state_in): LiveActions(state_in) {}
-    virtual ~MockLiveActions() {}
+    explicit MockLiveActions(const std::shared_ptr<State>& state_in): LiveActions(state_in) {}
+    ~MockLiveActions() {}
 
 protected:
-    void dispatch_url(const std::string& url) { last_url = url; }
-    void execute_command(const std::string& cmd) { last_cmd = cmd; }
+    void dispatch_url(const std::string& url) override { last_url = url; }
+    void execute_command(const std::string& cmd) override { last_cmd = cmd; }
 };
 
 /***
 
=== modified file 'tests/test-locations.cpp'
--- tests/test-locations.cpp	2014-07-13 22:22:57 +0000
+++ tests/test-locations.cpp	2014-09-17 16:59:23 +0000
@@ -47,7 +47,7 @@
     const std::string nyc = "America/New_York";
     const std::string chicago = "America/Chicago";
 
-    virtual void SetUp()
+    void SetUp() override
     {
       super::SetUp();
 
@@ -65,7 +65,7 @@
       m_timezones->timezones.set(std::set<std::string>({ nyc, chicago }));
     }
 
-    virtual void TearDown()
+    void TearDown() override
     {
       m_timezones.reset();
       m_settings.reset();
 
=== modified file 'tests/test-menus.cpp'
--- tests/test-menus.cpp	2014-06-27 01:52:36 +0000
+++ tests/test-menus.cpp	2014-09-17 16:59:23 +0000
@@ -39,7 +39,7 @@
     std::shared_ptr<MenuFactory> m_menu_factory;
     std::vector<std::shared_ptr<Menu>> m_menus;
 
-    virtual void SetUp()
+    void SetUp() override
     {
         super::SetUp();
 
@@ -49,7 +49,7 @@
             m_menus.push_back(m_menu_factory->buildMenu(Menu::Profile(i)));
     }
 
-    virtual void TearDown()
+    void TearDown() override
     {
         m_menus.clear();
         m_menu_factory.reset();
 
=== modified file 'tests/test-settings.cpp'
--- tests/test-settings.cpp	2014-09-02 15:37:03 +0000
+++ tests/test-settings.cpp	2014-09-17 16:59:23 +0000
@@ -39,7 +39,7 @@
     std::shared_ptr<Settings> m_settings;
     GSettings * m_gsettings;
 
-    virtual void SetUp()
+    void SetUp() override
     {
         super::SetUp();
 
@@ -48,7 +48,7 @@
         m_settings = std::dynamic_pointer_cast<Settings>(m_live);
     }
 
-    virtual void TearDown()
+    void TearDown() override
     {
         g_clear_object(&m_gsettings);
         m_settings.reset();
 
=== modified file 'tests/test-snap.cpp'
--- tests/test-snap.cpp	2014-07-31 22:06:50 +0000
+++ tests/test-snap.cpp	2014-09-17 16:59:23 +0000
@@ -96,7 +96,7 @@
   DbusTestDbusMockObject * screen_obj = nullptr;
   DbusTestDbusMockObject * haptic_obj = nullptr;
 
-  void SetUp()
+  void SetUp() override
   {
     GError * error = nullptr;
     char * str = nullptr;
@@ -269,18 +269,18 @@
     dbus_test_service_start_tasks(service);
     g_setenv("DBUS_SYSTEM_BUS_ADDRESS", g_getenv("DBUS_SESSION_BUS_ADDRESS"), TRUE);
 
-    session_bus = g_bus_get_sync(G_BUS_TYPE_SESSION, NULL, NULL);
+    session_bus = g_bus_get_sync(G_BUS_TYPE_SESSION, nullptr, nullptr);
     ASSERT_NE(nullptr, session_bus);
     g_dbus_connection_set_exit_on_close(session_bus, false);
     g_object_add_weak_pointer(G_OBJECT(session_bus), (gpointer *)&session_bus);
 
-    system_bus = g_bus_get_sync(G_BUS_TYPE_SYSTEM, NULL, NULL);
+    system_bus = g_bus_get_sync(G_BUS_TYPE_SYSTEM, nullptr, nullptr);
     ASSERT_NE(nullptr, system_bus);
     g_dbus_connection_set_exit_on_close(system_bus, FALSE);
     g_object_add_weak_pointer(G_OBJECT(system_bus), (gpointer *)&system_bus);
   }
 
-  virtual void TearDown()
+  void TearDown() override
   {
     g_clear_object(&haptic_mock);
     g_clear_object(&screen_mock);
 
=== modified file 'tests/test-timezone-file.cpp'
--- tests/test-timezone-file.cpp	2014-05-05 15:06:34 +0000
+++ tests/test-timezone-file.cpp	2014-09-17 16:59:23 +0000
@@ -52,12 +52,12 @@
 
   protected:
 
-    virtual void SetUp()
+    void SetUp() override
     {
       super::SetUp();
     }
 
-    virtual void TearDown()
+    void TearDown() override
     {
       super::TearDown();
     }
 
=== modified file 'tests/test-timezones.cpp'
--- tests/test-timezones.cpp	2014-01-22 15:06:01 +0000
+++ tests/test-timezones.cpp	2014-09-17 16:59:23 +0000
@@ -52,7 +52,7 @@
   std::string timezone_geo = "America/Denver";
 
   set_file(timezone_file);
-  std::shared_ptr<Settings> settings(new Settings);
+  auto settings = std::make_shared<Settings>();
   LiveTimezones z(settings, TIMEZONE_FILE);
   wait_msec(500); // wait for the bus to get set up
   EXPECT_EQ(timezone_file, z.timezone.get());