Merge lp:~charlesk/indicator-datetime/convergence into lp:~lukas-kde/indicator-datetime/convergence

Proposed by Charles Kerr
Status: Approved
Approved by: Lukáš Tinkl
Approved revision: 429
Proposed branch: lp:~charlesk/indicator-datetime/convergence
Merge into: lp:~lukas-kde/indicator-datetime/convergence
Diff against target: 21 lines (+2/-2)
1 file modified
tests/test-menus.cpp (+2/-2)
To merge this branch: bzr merge lp:~charlesk/indicator-datetime/convergence
Reviewer Review Type Date Requested Status
Lukáš Tinkl Approve
Review via email: mp+284477@code.launchpad.net

Commit message

Fixes tests to understand that calendar and location sections will be visible in the Phone profile.

Description of the change

Fixes tests to understand that calendar and location sections will be visible in the Phone profile.

To post a comment you must log in.
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

LGTM, makes sense

(sorry, I forgot about them in my initial MP)

review: Approve

Unmerged revisions

429. By Charles Kerr

sync unit tests with calendar, locations being visible in phone profile

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/test-menus.cpp'
2--- tests/test-menus.cpp 2015-03-15 02:31:42 +0000
3+++ tests/test-menus.cpp 2016-01-29 15:53:01 +0000
4@@ -102,7 +102,7 @@
5 else
6 expected_action = nullptr;
7
8- const auto calendar_expected = ((profile == Menu::Desktop) || (profile == Menu::DesktopGreeter))
9+ const auto calendar_expected = ((profile == Menu::Desktop) || (profile == Menu::DesktopGreeter) || (profile == Menu::Phone))
10 && (m_state->settings->show_calendar.get());
11
12 // get the calendar section
13@@ -420,7 +420,7 @@
14
15 void InspectLocations(GMenuModel* menu_model, Menu::Profile profile)
16 {
17- const bool locations_expected = profile == Menu::Desktop;
18+ const bool locations_expected = (profile == Menu::Desktop) || (profile == Menu::Phone);
19
20 // when there aren't any locations, confirm the menu is empty
21 const std::vector<Location> empty;

Subscribers

People subscribed via source and target branches

to all changes: