Indicator Date and Time

Code review comment for lp:~charlesk/indicator-datetime/always-get-initial-tzid-from-timedate1

  1. always-get-initial-tzid-from-timedate1
  2. Merge into trunk.15.10
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

code looks good, but the juggling with m_connection looks a bit brittle.

How about initializing m_connection in the constructor with g_bus_get_sync(), unreffing it in the destructor and using g_bus_watch_name_on_connection() for name watching?

review: Needs Information

« Back to merge proposal