Application Menu Indicator

Merge lp:~charlesk/indicator-appmenu/lp-957414 into lp:indicator-appmenu/0.4

  1. lp-957414
  2. Merge into trunk.0.4
Proposed by Charles Kerr
Status: Merged
Approved by: Charles Kerr
Approved revision: 181
Merged at revision: 182
Proposed branch: lp:~charlesk/indicator-appmenu/lp-957414
Merge into: lp:indicator-appmenu/0.4
Diff against target: 10 lines (+1/-0)
1 file modified
src/hudstringlist.c (+1/-0)
To merge this branch: bzr merge lp:~charlesk/indicator-appmenu/lp-957414
Reviewer Review Type Date Requested Status
Conor Curran (community) Approve
Review via email: mp+98000@code.launchpad.net

Description of the change

Add a comment to tell Coverity that we know what we're doing.

This is the same way we fixed Bug #943747: https://code.launchpad.net/~charlesk/indicator-datetime/fix-943747/+merge/95767

To post a comment you must log in.
Revision history for this message
Conor Curran (cjcurran) wrote :

nice

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/hudstringlist.c'
2--- src/hudstringlist.c 2012-02-29 19:51:31 +0000
3+++ src/hudstringlist.c 2012-03-16 21:51:21 +0000
4@@ -118,6 +118,7 @@
5
6 list = g_malloc (G_STRUCT_OFFSET (HudStringList, head) + headlen + 1);
7 list->tail = hud_string_list_ref (tail);
8+ /* coverity[secure_coding] */
9 strcpy (list->head, head);
10 list->ref_count = 1;
11

Subscribers

People subscribed via source and target branches