Merge lp:~charlesk/indicator-application/lp-1103087 into lp:indicator-application/13.04

Proposed by Charles Kerr
Status: Merged
Approved by: Lars Karlitski
Approved revision: 239
Merged at revision: 239
Proposed branch: lp:~charlesk/indicator-application/lp-1103087
Merge into: lp:indicator-application/13.04
Diff against target: 47 lines (+4/-3)
3 files modified
configure.ac (+3/-1)
debian/control (+1/-0)
src/application-service.c (+0/-2)
To merge this branch: bzr merge lp:~charlesk/indicator-application/lp-1103087
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+144390@code.launchpad.net

Description of the change

remove g_type_init() calls; introduce explicit glib requirements to configure.ac and debian/control

submitting for Jenkins to test b/c I haven't upgraded my glib yet

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2012-08-22 11:59:58 +0000
3+++ configure.ac 2013-01-22 20:34:23 +0000
4@@ -29,6 +29,7 @@
5 # Dependencies
6 ###########################
7
8+GLIB_REQUIRED_VERSION=2.35.4
9 GTK_REQUIRED_VERSION=3.0.0
10 GIO_REQUIRED_VERSION=2.26
11 INDICATOR_REQUIRED_VERSION=0.3.5
12@@ -38,8 +39,9 @@
13
14 LIBAPPINDICATOR_REQUIRED_VERSION=0.2.9
15
16-PKG_CHECK_MODULES(INDICATOR, gtk+-3.0 >= $GTK_REQUIRED_VERSION
17+PKG_CHECK_MODULES(INDICATOR, glib-2.0 >= $GLIB_REQUIRED_VERSION
18 gio-2.0 >= $GIO_REQUIRED_VERSION
19+ gtk+-3.0 >= $GTK_REQUIRED_VERSION
20 indicator3-0.4 >= $INDICATOR_REQUIRED_VERSION
21 json-glib-1.0 >= $JSON_GLIB_REQUIRED_VERSION
22 dbus-glib-1 >= $DBUS_GLIB_REQUIRED_VERSION
23
24=== modified file 'debian/control'
25--- debian/control 2012-11-21 16:20:13 +0000
26+++ debian/control 2013-01-22 20:34:23 +0000
27@@ -8,6 +8,7 @@
28 dbus-test-runner,
29 gnome-common,
30 xvfb,
31+ libglib2.0-dev (>= 2.35.4),
32 libgtk-3-dev (>= 2.91),
33 libdbus-glib-1-dev (>= 0.82),
34 libjson-glib-dev,
35
36=== modified file 'src/application-service.c'
37--- src/application-service.c 2012-02-04 02:34:52 +0000
38+++ src/application-service.c 2013-01-22 20:34:23 +0000
39@@ -52,8 +52,6 @@
40 int
41 main (int argc, char ** argv)
42 {
43- g_type_init();
44-
45 /* Bring us up as a basic indicator service */
46 service = indicator_service_new_version(INDICATOR_APPLICATION_DBUS_ADDR, INDICATOR_APPLICATION_SERVICE_VERSION);
47 g_signal_connect(G_OBJECT(service), INDICATOR_SERVICE_SIGNAL_SHUTDOWN, G_CALLBACK(service_disconnected), NULL);

Subscribers

People subscribed via source and target branches