lp:~charlesk/ido/lp-921065
- Get this branch:
- bzr branch lp:~charlesk/ido/lp-921065
Branch merges
- Conor Curran (community): Approve
-
Diff: 1042 lines (+121/-734)5 files modifiedsrc/Makefile.am (+0/-15)
src/idooffscreenproxy.c (+0/-515)
src/idooffscreenproxy.h (+0/-62)
src/idoscalemenuitem.c (+113/-140)
src/idoscalemenuitem.h (+8/-2)
Related bugs
Bug #921065: i-sound slider on unmute resets volume | Medium | Fix Released |
|
Related blueprints
Branch information
Recent revisions
- 102. By Charles Kerr
-
Fix LP Bug #906050 by removing idoscalemenuitem's offscreen proxy.
The offscreen proxy was added last September to fix bug #804009, but while testing in 12.04b1 I'm not able to reproduce that issue even after removing the offscreen proxy. I don't want to regress 804009 so I'll ask for more eyeballs on this one.
- 101. By Charles Kerr
-
don't override widget_
class.state_ changed in idoscalemenuitem ... that was preventing the prelight state from ever showing up there. - 100. By Ken VanDine
-
add style class "menubar" to the offscreen proxy, this fixes the white background drawn in the sound menu menu with the current gtk3/light-themes (LP: #925700)
- 99. By Ken VanDine
-
Patch from ~covox (LP: #867649)
In method ido_offscreen_
proxy_realize( ), a call is made to gdk_screen_ get_rgba_ visual( ) to get a GdkVisual handle, which is then passed as part of a GdkWindowAttr structure to gdk_window_new(). What's not taken into account is that gdk_screen_
get_rgba_ visual( ) will return NULL if RGBA isn't supported by the destination window manager (e.g. if someone turned the Composite extension off). In this case, as the field is always marked as valid for use (GDK_WA_VISUAL), gdk_window_new will fall over. Attached is a patch to fall back on gdk_screen_
get_system_ visual( ) if RGBA isn't available. With this, unity-panel-service no longer crashes after interacting with the Sound indicator if the Composite extension is switched off. - 98. By Ken VanDine
-
removed deprecations from gtk3 and fixed sizing issues with idemessagedialog (LP: #888392)
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:ido/0.3