lp:~charlesk/ido/lp-906050

Branch merges

Propose for merging

Merged into lp:ido/0.3

Conor Curran (community): Approve on 2012-03-12

Indicator Applet Developers: Pending requested 2012-03-10

Diff: 832 lines (+20/-695)

4 files modified

src/Makefile.am (+0/-15)
src/idooffscreenproxy.c (+0/-515)
src/idooffscreenproxy.h (+0/-62)
src/idoscalemenuitem.c (+20/-103)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #524541: Volume (slider) item isn't highlighted when selected	Medium	Fix Released
Bug #874431: All indicators crash when I click on sound indicator	Undecided	Fix Released
Bug #886335: Unable to use arrow keys to adjust the volume control in the sound menu.	High	Fix Released
Bug #906050: Playback controls don't highlight anything like other menu items	Medium	Invalid
Bug #945558: sound indicator renders incorrect when switching fast between indicators	High	Fix Released

Link a bug report

Related blueprints

104. By Charles Kerr on 2012-03-10

remove idooffscreenproxy

103. By Charles Kerr on 2012-03-10

small code cleanup in update_packing()

102. By Charles Kerr on 2012-03-10

Fix LP Bug #906050 by removing idoscalemenuitem's offscreen proxy.

The offscreen proxy was added last September to fix bug #804009, but while testing in 12.04b1 I'm not able to reproduce that issue even after removing the offscreen proxy. I don't want to regress 804009 so I'll ask for more eyeballs on this one.

101. By Charles Kerr on 2012-03-10

don't override widget_class.state_changed in idoscalemenuitem ... that was preventing the prelight state from ever showing up there.

100. By Ken VanDine on 2012-02-09

add style class "menubar" to the offscreen proxy, this fixes the white background drawn in the sound menu menu with the current gtk3/light-themes (LP: #925700)

99. By Ken VanDine on 2012-01-11

Patch from ~covox (LP: #867649)

In method ido_offscreen_proxy_realize(), a call is made to gdk_screen_get_rgba_visual() to get a GdkVisual handle, which is then passed as part of a GdkWindowAttr structure to gdk_window_new().

What's not taken into account is that gdk_screen_get_rgba_visual() will return NULL if RGBA isn't supported by the destination window manager (e.g. if someone turned the Composite extension off). In this case, as the field is always marked as valid for use (GDK_WA_VISUAL), gdk_window_new will fall over.

Attached is a patch to fall back on gdk_screen_get_system_visual() if RGBA isn't available. With this, unity-panel-service no longer crashes after interacting with the Sound indicator if the Composite extension is switched off.

98. By Ken VanDine on 2011-12-14

removed deprecations from gtk3 and fixed sizing issues with idemessagedialog (LP: #888392)

97. By Ted Gould on 2011-10-13

0.3.1

96. By Ted Gould on 2011-10-12

Fixes for ARM

95. By Michal Hruby on 2011-10-03

Merge lp:~mhr3/ido/bug-865122