Merge lp:~charlesk/hud/lp-1242032 into lp:hud/14.04

[Charles Kerr]

Add a nullptr safeguard to prevent a crash-on-null-ptr-reference.

Also, move a QMap lookup outside of a for loop. Yay!

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:341
http://jenkins.qa.ubuntu.com/job/hud-ci/155/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/hud-trusty-amd64-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/hud-trusty-armhf-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/hud-trusty-i386-ci/5/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/hud-ci/155/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:341
http://jenkins.qa.ubuntu.com/job/hud-ci/157/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-armhf-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-i386-ci/7

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/hud-ci/157/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:341
http://jenkins.qa.ubuntu.com/job/hud-ci/158/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-armhf-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-trusty-i386-ci/8

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/hud-ci/158/rebuild

review: Approve (continuous-integration)

[Ted Gould (ted)]

review: Approve

=== modified file 'window-stack-bridge/BamfWindowStack.cpp'
--- window-stack-bridge/BamfWindowStack.cpp	2013-10-11 11:18:33 +0000
+++ window-stack-bridge/BamfWindowStack.cpp	2013-10-28 16:16:04 +0000
@@ -194,8 +194,11 @@
 QStringList BamfWindowStack::GetWindowProperties(uint windowId,
 		const QString &appId, const QStringList &names) {
 	QStringList result;
-	for (const QString &name : names) {
-		result << m_windowsById[windowId]->xProp(name);
+	const auto window = m_windowsById[windowId];
+ 	if (window) {
+		for (const QString &name : names) {
+			result << window->xProp(name);
+		}
 	}
 	return result;
 }