Merge lp:~charlesk/bamf/fix-937402 into lp:bamf/0.4

Proposed by Charles Kerr
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 447
Merged at revision: 447
Proposed branch: lp:~charlesk/bamf/fix-937402
Merge into: lp:bamf/0.4
Diff against target: 36 lines (+4/-10)
1 file modified
tests/bamfdaemon/test-view.c (+4/-10)
To merge this branch: bzr merge lp:~charlesk/bamf/fix-937402
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+94033@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/bamfdaemon/test-view.c'
2--- tests/bamfdaemon/test-view.c 2012-01-03 16:23:18 +0000
3+++ tests/bamfdaemon/test-view.c 2012-02-21 18:07:33 +0000
4@@ -147,15 +147,15 @@
5 static void
6 test_path_collision (void)
7 {
8- BamfView *view;
9- GList *views, *l;
10 int i, j;
11
12 for (i = 0; i < 20; i++)
13 {
14+ GList *views = NULL;
15+
16 for (j = 0; j < 2000; j++)
17 {
18- view = g_object_new (BAMF_TYPE_VIEW, NULL);
19+ BamfView * view = g_object_new (BAMF_TYPE_VIEW, NULL);
20 g_assert (BAMF_IS_VIEW (view));
21
22 views = g_list_prepend (views, view);
23@@ -163,13 +163,7 @@
24 bamf_view_export_on_bus (view, gdbus_connection);
25 }
26
27- for (l = views; l; l = l->next)
28- {
29- g_object_unref (l->data);
30- }
31-
32- g_list_free (views);
33- views = NULL;
34+ g_list_free_full (views, g_object_unref);
35 }
36 }
37

Subscribers

People subscribed via source and target branches