Code review comment for lp:~charlesk/appmenu-gtk/lp-787736

Revision history for this message
Charles Kerr (charlesk) wrote :

* wrt rebuild_list_clear being called twice, yes. I was continuing the double-clear behavior that's been in place since but it's not clear to me if the original behavior was necessary or accidental.

* removing sources in their callbacks works fine.

* Ah, G_SOURCE_REMOVE is a nice mnemonic device. I didn't know about that!

« Back to merge proposal