Code review comment for lp:~charlesk/appmenu-gtk/lp-787736

Revision history for this message
Lars Karlitski (larsu) wrote :

That's much cleaner, I like it.

* rebuild_list_clear is called in both dispose and in finalize

* rebuild_timer_func is the callback for the timer to rebuild widgets. It calls rebuild_list_clear, which removes the timer source with g_source_remove. Is removing sources in their callbacks allowed?

* you could be making life easier for this particular reviewer if you return G_SOURCE_REMOVE instead of FALSE in rebuild_timer_func (he has trouble remembering if TRUE or FALSE remove a source)

review: Needs Information

« Back to merge proposal