lp:~charlesk/appmenu-gtk/lp-787736

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:appmenu-gtk/12.10 at revision 158

jenkins (community): Needs Fixing (continuous-integration) on 2012-08-31

Lars Karlitski (community): Approve on 2012-08-30

Indicator Applet Developers: Pending requested 2012-04-26

Diff: 218 lines (+90/-79)

1 file modified

src/bridge.c (+90/-79)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #787736: RebuildData structs are leaked in rebuild() / do_rebuild()

Medium

Fix Released

Link a bug report

Related blueprints

158. By Charles Kerr on 2012-08-30

don't double-call rebuild_list_clear()

157. By Charles Kerr on 2012-08-30

in bridge.c(), have rebuild_timer_func() return G_SOURCE_REMOVE instead of FALSE because the former is more readable.

156. By Charles Kerr on 2012-08-29

copyediting: use gtk coding style for the new code

155. By Charles Kerr on 2012-08-29

sync with lp:appmenu-gtk

154. By Charles Kerr on 2012-04-26

Fix the leaked RebuildData structs in appmenu/bridge.c

The problem:

 To batch up menu changes, appmenu has a 100 msec timer for
 each menu item that changes. It rebuilds our copy after that
 timer fires. There's a RebuildData context struct to that timer
 and a global static hashtable of the widget-to-timer_id
 associations. When a widget changes again while it's got a
 pending timer, the previous timer is removed and a new one
 is added, leaking the previous RebuildData. _add_timeout_full()
 is one way to fix this, but a second problem is having all this
 play nicely with weak references s.t. we don't try to rebuild
 widgets that get destroyed.

This fix:

 This patch fixes the leak and simplifies the code by removing
 RebuildData, the global hashtable, and the new-timer-per-widget.

 The bridge now has a single timer and a list of widgets that
 need to get rebuilt when the timer fires. When a weak reference
 indicates a widget has been destroyed, the only thing we have to
 do is remove it from the list.

153. By Charles Kerr on 2012-04-26

remove dead code

152. By Charles Kerr on 2012-04-04

0.3.92

151. By Charles Kerr on 2012-04-04

merge lp:~allanlesage/appmenu-gtk/TDD to add gcov targets to autotools build for code-coverage reporting. For more information, see this blog post: http://qualityhour.wordpress.com/2012/01/29/test-coverage-tutorial-for-cc-autotools-projects/

150. By Charles Kerr on 2012-04-02

merge lp:~desrt/appmenu-gtk/gdkthreads-fix to use gdkthreads when scheduling a timeout for compatibility with apps using gdkthreads.

149. By Michael Terry on 2012-04-02

blacklist glade