Merge lp:~charlesk/appmenu-gtk/lp-1053795 into lp:appmenu-gtk/12.10

Proposed by Charles Kerr
Status: Merged
Approved by: Lars Karlitski
Approved revision: 160
Merged at revision: 160
Proposed branch: lp:~charlesk/appmenu-gtk/lp-1053795
Merge into: lp:appmenu-gtk/12.10
Diff against target: 39 lines (+1/-7)
1 file modified
src/bridge.c (+1/-7)
To merge this branch: bzr merge lp:~charlesk/appmenu-gtk/lp-1053795
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
jenkins (community) continuous-integration Approve
Review via email: mp+125867@code.launchpad.net

Commit message

Remove bridge's "rebuild" debug statements.

Description of the change

Remove bridge's "rebuild" debug statements. They're not very useful and they generate a lot of noise when enabling debug messages on end-user apps.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Approve (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/bridge.c'
2--- src/bridge.c 2012-09-18 20:06:50 +0000
3+++ src/bridge.c 2012-09-23 00:30:26 +0000
4@@ -222,7 +222,6 @@
5 {
6 GSList * l;
7 AppMenuBridgePrivate * p = bridge->priv;
8- g_debug (G_STRLOC" clearing bridge %p's rebuild list", bridge);
9
10 /* unref the widgets and blow away the list */
11 for (l=p->rebuild_list; l!=NULL; l=l->next)
12@@ -541,10 +540,7 @@
13 GtkWidget * w = GTK_WIDGET(l->data);
14
15 if (gtk_widget_is_toplevel(w))
16- {
17- g_debug (G_STRLOC" rebuilding bridge %p's toplevel %p", bridge, w);
18- rebuild_window_items (bridge, w);
19- }
20+ rebuild_window_items (bridge, w);
21 }
22
23 /* cleanup */
24@@ -564,7 +560,6 @@
25 /* ensure there's a rebuild timer ticking */
26 if (p->rebuild_timer_id == 0)
27 {
28- g_debug (G_STRLOC" creating rebuild timer");
29 p->rebuild_timer_id = gdk_threads_add_timeout (100,
30 rebuild_timer_func,
31 bridge);
32@@ -574,7 +569,6 @@
33 if (g_slist_find (p->rebuild_list, toplevel) == NULL)
34 {
35 GObject * o = G_OBJECT(toplevel);
36- g_debug (G_STRLOC" adding widget %p to bridge %p's queue", o, bridge);
37 p->rebuild_list = g_slist_prepend (p->rebuild_list, o);
38 g_object_weak_ref (o, rebuild_list_widget_destroyed, bridge);
39 }

Subscribers

People subscribed via source and target branches