Code review comment for lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug

Revision history for this message
Chad Smith (chad.smith) wrote :

> What happens when you remove the original eth0 and replace it? Does the boot
> happen promptly, or does it stall on the 50-cloud-init.yaml interface?
>
> Would it be simpler just to suppress the original cloud-init netplan config?
>
> Apart from that I think it looks fine, but I'm not an expert on how these
> things are built.

Thanks for the thoughts here Daniel.

I had tested detaching the original nic (which had cloud-init's matched macaddress), and attaching a new nic (new mac) which showed up as eth0. On boot, the new nic didn't match systemd's match rule emitted by netplan due to 50-cloud-init.yaml. systemd-analyze showed no timeout or wait attempts on 50-cloud-init's declared non-optional device.

I'm seeing `systemd-analyze blame` without any timeouts:
...
           989ms systemd-networkd-wait-online.service
...

This reason that boot online didn't wait is networkd's intended behavior, any unmatched network device doesn't honor any additional config (like RequiredForOnline=yes) because that device isn't currently managed by networkd, so it won't wait around for that additional device that doesn't even exist.

The only time network-wait-online will wait, is for matches devices that are present on the system, and specify RequiredForOnline=yes.

« Back to merge proposal