lp:~chad.smith/landscape-client/ha-manager-skeleton
Created by
Chad Smith
and last modified
- Get this branch:
- bzr branch lp:~chad.smith/landscape-client/ha-manager-skeleton
Only
Chad Smith
can upload to this branch. If you are
Chad Smith
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- Jerry Seutter (community): Approve
- Christopher Armstrong (community): Approve
-
Diff: 597 lines (+547/-3)5 files modifiedlandscape/manager/config.py (+1/-1)
landscape/manager/haservice.py (+205/-0)
landscape/manager/tests/test_config.py (+2/-1)
landscape/manager/tests/test_haservice.py (+331/-0)
landscape/message_schemas.py (+8/-1)
Related bugs
Related blueprints
Branch information
Recent revisions
- 634. By Chad Smith
-
charm directory needs to tack on the 'charm' subdir for housing all charm deliverables. An example: /var/lib/
juju/units/ keystone- 2/charm/ - 632. By Chad Smith
-
- add _respond_
failure_ string to handle failure strings using logging.error.
- _respond_failure handles any raised exceptions using log_failure - 631. By Chad Smith
-
per review comments:
- drop unnneeded run_parts method in favor of inline
- use log_failure instead of logging.error
- drop format_exception and use Failure() instead
- on success, instead of return succeed("some string") just return "some string"
- raise CharmScriptError instead of return fail(CharmScriptError) - 629. By Chad Smith
-
reintroduce CharmScriptError and RunPartsError to return as twisted deferred fails.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:~landscape/landscape-client/trunk