~chad.smith/curtin:error-logs-tarfile

Branch merges

Propose for merging

Merged into curtin:master at revision dcc7fcc593bc56e87e4be7a6c2761fd68e943fb6

Server Team CI bot: Approve (continuous-integration) on 2018-01-30

Scott Moser (community): Approve on 2018-01-30

Diff: 442 lines (+179/-38)

6 files modified

curtin/commands/collect_logs.py (+3/-14)
curtin/commands/install.py (+12/-5)
doc/topics/config.rst (+10/-1)
tests/unittests/test_commands_collect_logs.py (+12/-15)
tests/unittests/test_commands_install.py (+138/-1)
tests/unittests/test_pack.py (+4/-2)

api

Superseded for merging into curtin:master

Server Team CI bot: Approve (continuous-integration) on 2018-01-17

curtin developers: Pending requested 2018-01-17

Diff: 959 lines (+717/-17)

9 files modified

curtin/commands/collect_logs.py (+175/-0)
curtin/commands/install.py (+21/-9)
curtin/commands/main.py (+3/-2)
curtin/util.py (+24/-4)
doc/topics/config.rst (+16/-2)
tests/unittests/test_commands_collect_logs.py (+310/-0)
tests/unittests/test_commands_install.py (+144/-0)
tests/unittests/test_reporter.py (+16/-0)
tests/unittests/test_util.py (+8/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

7c989d6... by Chad Smith on 2018-01-30

revert doc whitespace change around dd-img

13114da... by Chad Smith on 2018-01-30

drop save_error_tarfile from docs

1a385f7... by Chad Smith on 2018-01-29

revert driveby doc change dd-img -> dd-raw

1864c9d... by Chad Smith on 2018-01-29

resolve rebase conflicts. Provide error_tarfile None to test_pack unit test to avoid triggering leaked sudo on create_log_tarfile() call during test error condition

b99e2cf... by Chad Smith on 2018-01-29

lint

9cd0ae1... by Chad Smith on 2018-01-29

drop save_error_tarfile as we won't get to a properly installed save target if curtin errors. Avoid subp sudo leak in test_pack during error_log collection by providing error_tarfile = None so error logs aren't created. Adapt save_tarfile unit test to instead test error_tarfile None

b0473cf... by Chad Smith on 2018-01-29

rename _create_tarfile as public function create_log_tarfile

08c9060... by Chad Smith on 2018-01-17

add unit tests for configuring and writing error tarfiles from cmd_install. Use deepcopy for CONFIG_BUILTIN to avoid manipulating the deep source dict in unit tests. Pull workind creation up dd_images error check as raised ValueError results in a traceback in 'finally' when trying to reference undeclared variable workingd.

63018ff... by Chad Smith on 2018-01-17

fix docs which mentiond unsupported dd-img in examples instead of dd-raw

ecc5dd2... by Chad Smith on 2018-01-16

add install:error_tarfile and save_error_tarfile options to auto-collect logs upon curtin error