~chad.smith/cloud-init:bug/1776701-openstack-local-no-probe-on-ec2

Branch merges

Propose for merging

Merged into cloud-init:master at revision 1efa8a0a030794cec68197100f31a856d0d264ab

Chad Smith: Abstain on 2018-06-16

Scott Moser: Approve on 2018-06-16

Server Team CI bot: Approve (continuous-integration) on 2018-06-15

Diff: 333 lines (+182/-16)

5 files modified

cloudinit/sources/DataSourceOpenStack.py (+23/-0)
cloudinit/util.py (+11/-2)
doc/rtd/topics/datasources/openstack.rst (+15/-0)
tests/unittests/test_datasource/test_openstack.py (+110/-14)
tests/unittests/test_util.py (+23/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

8266327... by Chad Smith on 2018-06-16

proper mock of get_proc_env in unit tests

69b6200... by Chad Smith on 2018-06-15

doc update

c3183e9... by Chad Smith on 2018-06-15

define top-level constants VALID_DMI_PRODUCT_NAMES and VALID_DMI_ASSET_TAGS

4055f7d... by Chad Smith on 2018-06-15

use is_x86 in read_dmi_data and add unit test for it

760279f... by Chad Smith on 2018-06-15

fix unit tests to mock is_x86 instead of uname

44caa4a... by Chad Smith on 2018-06-15

pyflakes and pycodestyle

2effe5c... by Chad Smith on 2018-06-14

fix unit tests given use of get_proc_env

9a475d0... by Chad Smith on 2018-06-14

doc tweak

9c9f6ab... by Chad Smith on 2018-06-14

add Discovery section to OpenStack datasource RTD

c84f679... by Chad Smith on 2018-06-14

address review comments

- magic variables at the top of DataSourceOpenStack
- use util.get_proc_env instead of rolling our own
- add util.is_x86 with efficient string checks for matching
architecture use is_x86 in detect_openstack