Merge ~chad.smith/cloud-init:fix/opennebula-exclude-epochseconds into cloud-init:master

[Chad Smith]

opennebula: also exclude epochseconds from changed environment vars

In addition to EPOCHREALTIME there is also an EPOCHSECONDS environment
variable that OpenNebula needs to exclude as it is expected to change.
This commit supplements the other exclusion in commit
d1a2fe7307e9cf2251d1f9a666c12d71d3f522d6.

Without this fix, unittests will intermittently fail if
parse_shell_config is run across a timing boundary where the
EPOCHSECONDS changes mid-test.

LP: #1813641

[Ryan Harper (raharper)]

Newer bash (5.0) has these new variables, BASH_ARGV0, EPOCHSECONDS, and EPOCHREALTIME.

I don't think that the datasource invokes bash differently, nor do I think the config they source would be setting it; however; it is mutable, so maybe we want to also exclude that as well?

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:ed4e35e2965e67d14d5f814ead85eb2e69f49ceb
https://jenkins.ubuntu.com/server/job/cloud-init-ci/547/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/547/rebuild

review: Approve (continuous-integration)

[Ryan Harper (raharper)]

I'll defer to your thoughts on this; so approving whether you add that to the excluded list or leave it as it is.

review: Approve

[Chad Smith (chad.smith)]

Thanks Ryan. As you suggest, while it's true that bash surfaces ARGV0, cloud-init's calling of that utility doesn't change across invocations, so we won't get affected by BASH_ARGV0 changing. Will leave as is.

diff --git a/cloudinit/sources/DataSourceOpenNebula.py b/cloudinit/sources/DataSourceOpenNebula.py
index 6e1d04b..02c9a7b 100644
--- a/cloudinit/sources/DataSourceOpenNebula.py
+++ b/cloudinit/sources/DataSourceOpenNebula.py
@@ -337,7 +337,9 @@ def parse_shell_config(content, keylist=None, bash=None, asuser=None,
     (output, _error) = util.subp(cmd, data=bcmd)
 
     # exclude vars in bash that change on their own or that we used
-    excluded = ("EPOCHREALTIME", "RANDOM", "LINENO", "SECONDS", "_", "__v")
+    excluded = (
+        "EPOCHREALTIME", "EPOCHSECONDS", "RANDOM", "LINENO", "SECONDS", "_",
+        "__v")
     preset = {}
     ret = {}
     target = None