Code review comment for ~chad.smith/cloud-init:set-hostname-before-network
Revision history for this message
| Scott Moser (smoser) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
My only comment at this point is wheter or not we should bother with calling the config module and writing the marker file and such at that point.
the other option is to just set it.
The other thoughts (i guess i did have more than one)
a.) we have had issues with setting hostname not being possible early in boot due to that being a systemd service (hostnamectl) .
b.) we want to somehow make sure that we only set this hostname on first instance boot. We don't want to overwrite what a user configured manually.
I think that your use of config module probably handles that, but just want to write those thoughts down.