Merge lp:~chad.smith/charms/precise/keystone/keystone-health-updates into lp:~openstack-charmers/charms/precise/keystone/ha-support

Proposed by Chad Smith
Status: Merged
Merged at revision: 61
Proposed branch: lp:~chad.smith/charms/precise/keystone/keystone-health-updates
Merge into: lp:~openstack-charmers/charms/precise/keystone/ha-support
Diff against target: 23 lines (+5/-3)
2 files modified
hooks/keystone_hooks.py (+4/-2)
revision (+1/-1)
To merge this branch: bzr merge lp:~chad.smith/charms/precise/keystone/keystone-health-updates
Reviewer Review Type Date Requested Status
James Page Approve
Adam Gandelman Pending
Review via email: mp+155770@code.launchpad.net

Description of the change

Update health scripts with changes in how keystone internal service port numbers are now defined using cluster.determine_api_port

To post a comment you must log in.
Revision history for this message
Chad Smith (chad.smith) wrote :

question on cluster.determine_api_port on HA passive versus active units. will determine_api_port return the public port on the leader versus the private private port on the passive unit?

Revision history for this message
James Page (james-page) wrote :

Determine API port will give you the port that the actual keystone service is listening on rather than the haproxy or the apache https port if configured.

Revision history for this message
James Page (james-page) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/keystone_hooks.py'
2--- hooks/keystone_hooks.py 2013-03-19 13:50:23 +0000
3+++ hooks/keystone_hooks.py 2013-03-27 15:45:33 +0000
4@@ -372,8 +372,10 @@
5 do_openstack_upgrade(config['openstack-origin'], ' '.join(packages))
6
7 env_vars = {'OPENSTACK_SERVICE_KEYSTONE': 'keystone',
8- 'OPENSTACK_PORT_ADMIN': config['admin-port'],
9- 'OPENSTACK_PORT_PUBLIC': config['service-port']}
10+ 'OPENSTACK_PORT_ADMIN': cluster.determine_api_port(
11+ config['admin-port']),
12+ 'OPENSTACK_PORT_PUBLIC': cluster.determine_api_port(
13+ config['service-port'])}
14 save_script_rc(**env_vars)
15
16 set_admin_token(config['admin-token'])
17
18=== modified file 'revision'
19--- revision 2013-03-21 18:25:39 +0000
20+++ revision 2013-03-27 15:45:33 +0000
21@@ -1,1 +1,1 @@
22-212
23+213

Subscribers

People subscribed via source and target branches