Merge lp:~chad.smith/apport/add-multichar-response-for-long-lists into lp:~apport-hackers/apport/trunk
Proposed by
Chad Smith
Status: | Merged |
---|---|
Merged at revision: | 3168 |
Proposed branch: | lp:~chad.smith/apport/add-multichar-response-for-long-lists |
Merge into: | lp:~apport-hackers/apport/trunk |
Diff against target: |
60 lines (+23/-7) 1 file modified
bin/apport-cli (+23/-7) |
To merge this branch: | bzr merge lp:~chad.smith/apport/add-multichar-response-for-long-lists |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Scott Moser (community) | Approve | ||
Apport upstream developers | Pending | ||
Review via email: mp+332729@code.launchpad.net |
Description of the change
In cloud-init we have apport cli prompts what cloud are you on. Since there are two character responses required for options >= 10 we can't have apport limit the response to a single character.
This branch fixes lp: #1722564 by forcing apport to readline instead of read(1) for a given prompt if that prompt is > 10 choices (1-9 + the letter C (cancel)).
To post a comment you must log in.
This approach seems sane to me.
It preserves the old behavior of 1 character input for the vast majority of users.
In cases where there is > 10 choices, the user has to hit Enter, which is quite a common behavior.