Code review comment for lp:~cgregan/checkbox/usb-performance

Revision history for this message
Daniel Manrique (roadmr) wrote :

The commands are both the same, and contain the parameters for USB 3.0 (particularly the -m value will not allow this to work with a USB 2.0 device).

So the command for USB 2.0 needs updating, I'd remove the -m parameter and value, and set a lower threshold (-p value). Theoretical max for USB 2.0 is 60 MB/s (vs. 625 MB/s for USB 3.0).

Since we're generically asking for "usb storage device" and not "hard disk", the actual transfer speed will be much lower, I suggest doing some tests with usb sticks and deciding on a threshold. For reference, USB 1.0 transferred at 1.5 MB/s, so we definitely want something higher than that for USB 2.0.

review: Needs Fixing

« Back to merge proposal