Merge lp:~cgregan/checkbox/usb-performance into lp:checkbox

Proposed by Chris Gregan on 2014-02-24
Status: Rejected
Rejected by: Daniel Manrique on 2014-04-03
Proposed branch: lp:~cgregan/checkbox/usb-performance
Merge into: lp:checkbox
Diff against target: 33 lines (+26/-0)
1 file modified
checkbox-old/jobs/usb.txt.in (+26/-0)
To merge this branch: bzr merge lp:~cgregan/checkbox/usb-performance
Reviewer Review Type Date Requested Status
Daniel Manrique 2014-02-24 Needs Information on 2014-03-13
Brendan Donegan (community) Needs Fixing on 2014-02-25
Review via email: mp+208026@code.launchpad.net
To post a comment you must log in.
Chris Gregan (cgregan) wrote :

Added usb/usb3 performance

Daniel Manrique (roadmr) wrote :

The commands are both the same, and contain the parameters for USB 3.0 (particularly the -m value will not allow this to work with a USB 2.0 device).

So the command for USB 2.0 needs updating, I'd remove the -m parameter and value, and set a lower threshold (-p value). Theoretical max for USB 2.0 is 60 MB/s (vs. 625 MB/s for USB 3.0).

Since we're generically asking for "usb storage device" and not "hard disk", the actual transfer speed will be much lower, I suggest doing some tests with usb sticks and deciding on a threshold. For reference, USB 1.0 transferred at 1.5 MB/s, so we definitely want something higher than that for USB 2.0.

review: Needs Fixing
Brendan Donegan (brendan-donegan) wrote :

Are we sure this is the approach we want to take for USB? For mediacards it makes sense because of the variables in testing those, but for USB it might be feasible to automate it. If we do want to take this approach, no problem - I can update my merge requests to not touch the performance tests.

Brendan Donegan (brendan-donegan) wrote :

Apart from that, echoing mostly what Daniel said - the usb/usb-performance job needs to have its -m value reduced/removed - currently it will only work with usb 3.0 devices. Additionally, both jobs need estimated_duration and if we're taking the manual route then we can remove the -p option altogether since we don't want to test what the transfer speed was (just display it)

review: Needs Fixing
Daniel Manrique (roadmr) wrote :

Didn't we do this in another branch already? If so, let's reject this MR. Let me know.

review: Needs Information
Chris Gregan (cgregan) wrote :

yes...lemme add yout name to the branch I created yesterday

On Thu, Mar 13, 2014 at 2:12 PM, Daniel Manrique <
<email address hidden>> wrote:

> Review: Needs Information
>
> Didn't we do this in another branch already? If so, let's reject this MR.
> Let me know.
> --
> https://code.launchpad.net/~cgregan/checkbox/usb-performance/+merge/208026
> You are the owner of lp:~cgregan/checkbox/usb-performance.
>

--
Chris Gregan
Project Quality Manager
Professional and Engineering Services
Canonical USA Inc.
<email address hidden>
cgregan[irc.freenode.net]
W-781-761-9448

----
1024/8806032D
E70F 7391 6C78 9B9E 6461 1CC7 B168 E1E7 8806 032D

Daniel Manrique (roadmr) wrote :

Not needed anymore, so let's reject to remove from the list of pending reviews.

Unmerged revisions

2710. By Chris Gregan on 2014-02-24

updated with tests for manual performance measures of usb and usb3

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-old/jobs/usb.txt.in'
2--- checkbox-old/jobs/usb.txt.in 2013-10-01 19:28:58 +0000
3+++ checkbox-old/jobs/usb.txt.in 2014-02-24 21:50:18 +0000
4@@ -199,3 +199,29 @@
5 user: root
6 command: disk_read_performance_test `ls /sys$path/block | sed 's|!|/|'`
7 EOF
8+
9+plugin: user-interact-verify
10+name: usb/usb-performance-manual
11+user: root
12+command: removable_storage_test -s 268400000 -m 500000000 -p 20 usb | cat - <(echo; echo "Verify the result and click OK to decide on the outcome") | zenity --text-info --title 'USB Performance'
13+_description:
14+ PURPOSE:
15+ This test will check your USB data transfer performance.
16+ STEPS:
17+ 1. Connect a USB storage device to an external USB slot on this computer.
18+ 2. Click the test button to perform the test.
19+ VERIFICATION:
20+ Did the results of the test match the expected performance of the inserted device?
21+
22+plugin: user-interact-verify
23+name: usb3/usb3-performance-manual
24+user: root
25+command: removable_storage_test -s 268400000 -m 500000000 -p 20 usb | cat - <(echo; echo "Verify the result and click OK to decide on the outcome") | zenity --text-info --title 'USB Performance'
26+_description:
27+ PURPOSE:
28+ This test will check your USB data transfer performance.
29+ STEPS:
30+ 1. Connect a USB3 storage device to an external USB slot on this computer.
31+ 2. Click the test button to perform the test.
32+ VERIFICATION:
33+ Did the results of the test match the expected performance of the inserted device?

Subscribers

People subscribed via source and target branches