Code review comment for lp:~cgregan/checkbox/audio_dolby

Zygmunt Krynicki (zyga) wrote :

Thanks for getting in touch with Dolby. This would be a great asset.

On Fri, Jan 17, 2014 at 4:51 PM, Chris Gregan <email address hidden>wrote:

> ok..I can re-work the case...np. Also, I've sent an email to Dolby legal to
> get some clarification around the licenses governing the mp4 content on
> their site.
>
>
> On Fri, Jan 17, 2014 at 10:03 AM, Zygmunt Krynicki <
> <email address hidden>> wrote:
>
> > Review: Needs Fixing
> >
> > Chris, you know I'm about to say this but the test description is *bad*:
> > indicate the codec name used, this is *essential* as it will fail on my
> > setup for the well-expected reason. I think we could try paplay
> > --passthrough as totem cannot properly enable passthrogh on any other
> codec
> > that I've tried and this test is bound to be copy-pasted to into other
> > tests.
> > --
> > https://code.launchpad.net/~cgregan/checkbox/audio_dolby/+merge/202091
> > You are the owner of lp:~cgregan/checkbox/audio_dolby.
> >
>
>
>
> --
> Chris Gregan
> Project Quality Manager
> Professional and Engineering Services
> Canonical USA Inc.
> <email address hidden>
> cgregan[irc.freenode.net]
> W-781-761-9448
>
> ----
> 1024/8806032D
> E70F 7391 6C78 9B9E 6461 1CC7 B168 E1E7 8806 032D
>
> https://code.launchpad.net/~cgregan/checkbox/audio_dolby/+merge/202091
> You are reviewing the proposed merge of lp:~cgregan/checkbox/audio_dolby
> into lp:checkbox.
>

« Back to merge proposal