Merge lp:~cgb-cs/appscale/main-cloud-as-xen-support into lp:appscale

Proposed by Chris Bunch
Status: Rejected
Rejected by: Navraj Chohan
Proposed branch: lp:~cgb-cs/appscale/main-cloud-as-xen-support
Merge into: lp:appscale
Diff against target: 30 lines (+15/-3)
1 file modified
AppController/djinn.rb (+15/-3)
To merge this branch: bzr merge lp:~cgb-cs/appscale/main-cloud-as-xen-support
Reviewer Review Type Date Requested Status
Navraj Chohan (community) Disapprove
Review via email: mp+77360@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Navraj Chohan (nchohan) :
review: Disapprove

Unmerged revisions

787. By Chris Bunch

adding ability for appcontroller to use different IPs for Xen-style deployments (e.g., public and private ips)

786. By Navraj Chohan <email address hidden>

disabled firewall

785. By root <root@appscale-image0>

added redisdb to AppScale

784. By root <root@perl>

public to private ips where needed

783. By root <root@lucid>

apt-get update before adding python tools

782. By root <root@appscale-image0>

updates to build; mysql fix

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'AppController/djinn.rb'
2--- AppController/djinn.rb 2011-09-18 03:02:52 +0000
3+++ AppController/djinn.rb 2011-09-28 16:25:10 +0000
4@@ -1332,11 +1332,23 @@
5 machine, instance_type, keyname, infrastructure, "cloud1")
6 else
7 nodes.each_pair do |ip,roles|
8- # for xen the public and private ips are the same
9+ # If deploying over locally managed Xen boxes, public ip = private ip
10+ # Otherwise, the user has to give us the public and private IPs
11+
12 # and we call it cloud1 since the first key (only key)
13 # is the key to use
14-
15- info = "#{ip}:#{ip}:#{roles}:i-SGOOBARZ:cloud1"
16+
17+ public_ip = ip
18+ private_ip = ip
19+
20+ if ip.include?("/")
21+ public_ip, private_ip = ip.split("/")
22+ end
23+
24+ public_ip.strip!
25+ private_ip.strip!
26+
27+ info = "#{public_ip}:#{private_ip}:#{roles}:i-SGOOBARZ:cloud1"
28 appengine_info << info
29 Djinn.log_debug("Received appengine info: #{info}")
30 end

Subscribers

People subscribed via source and target branches