Merge lp:~cern-kicad/kicad/bugfix_1283396 into lp:kicad/product

[Maciej Suminski]

[Ian O'Hara (ianohara)]

Hi,

Just for my own education, are negative net numbers ever valid (are they used for a special purpose or something?)? Also, is netcode 0 valid and/or special?

Thanks,
Ian

[Maciej Suminski (orsonmmz)]

Hi Ian,

The only situation I have seen negative net numbers is when there is a zone that used to be connected to a net that does not exist anymore. Netcode 0 is reserved for unconnected items.

Regards,
Orson

=== modified file 'pcbnew/ratsnest_data.cpp'
--- pcbnew/ratsnest_data.cpp	2014-01-26 21:01:42 +0000
+++ pcbnew/ratsnest_data.cpp	2014-03-01 20:28:15 +0000
@@ -801,26 +801,40 @@
 {
     m_nets.clear();
     m_nets.resize( m_board->GetNetCount() );
+    int netCode;
 
     // Iterate over all items that may need to be connected
     for( MODULE* module = m_board->m_Modules; module; module = module->Next() )
     {
         for( D_PAD* pad = module->Pads().GetFirst(); pad; pad = pad->Next() )
-            m_nets[pad->GetNet()].AddItem( pad );
+        {
+            netCode = pad->GetNet();
+
+            if( netCode > 0 )
+                m_nets[netCode].AddItem( pad );
+        }
     }
 
     for( TRACK* track = m_board->m_Track; track; track = track->Next() )
     {
-        if( track->Type() == PCB_VIA_T )
-            m_nets[track->GetNet()].AddItem( static_cast<SEGVIA*>( track ) );
-        else if( track->Type() == PCB_TRACE_T )
-            m_nets[track->GetNet()].AddItem( track );
+        netCode = track->GetNet();
+
+        if( netCode > 0 )
+        {
+            if( track->Type() == PCB_VIA_T )
+                m_nets[netCode].AddItem( static_cast<SEGVIA*>( track ) );
+            else if( track->Type() == PCB_TRACE_T )
+                m_nets[netCode].AddItem( track );
+        }
     }
 
     for( int i = 0; i < m_board->GetAreaCount(); ++i )
     {
         ZONE_CONTAINER* zone = m_board->GetArea( i );
-        m_nets[zone->GetNet()].AddItem( zone );
+        netCode = zone->GetNet();
+
+        if( netCode > 0 )
+            m_nets[netCode].AddItem( zone );
     }
 }