Merge lp:~cern-kicad/kicad/bugfix_1265354 into lp:kicad/product

Proposed by Maciej Suminski
Status: Merged
Merged at revision: 4654
Proposed branch: lp:~cern-kicad/kicad/bugfix_1265354
Merge into: lp:kicad/product
Diff against target: 70 lines (+27/-20)
2 files modified
pcbnew/class_text_mod.cpp (+26/-19)
pcbnew/ratsnest_data.cpp (+1/-1)
To merge this branch: bzr merge lp:~cern-kicad/kicad/bugfix_1265354
Reviewer Review Type Date Requested Status
KiCad Lead Developers Pending
Review via email: mp+204426@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'pcbnew/class_text_mod.cpp'
2--- pcbnew/class_text_mod.cpp 2013-12-20 09:15:00 +0000
3+++ pcbnew/class_text_mod.cpp 2014-02-03 07:59:14 +0000
4@@ -417,28 +417,35 @@
5
6 void TEXTE_MODULE::ViewGetLayers( int aLayers[], int& aCount ) const
7 {
8- switch( m_Type )
9- {
10- case TEXT_is_REFERENCE:
11- aLayers[0] = ITEM_GAL_LAYER( MOD_REFERENCES_VISIBLE );
12- break;
13-
14- case TEXT_is_VALUE:
15- aLayers[0] = ITEM_GAL_LAYER( MOD_VALUES_VISIBLE );
16- break;
17-
18- default:
19- switch( GetParent()->GetLayer() )
20+ if( m_NoShow ) // Hidden text
21+ {
22+ aLayers[0] = ITEM_GAL_LAYER( MOD_TEXT_INVISIBLE );
23+ }
24+ else
25+ {
26+ switch( m_Type )
27 {
28- case LAYER_N_BACK:
29- aLayers[0] = ITEM_GAL_LAYER( MOD_TEXT_BK_VISIBLE ); // how about SILKSCREEN_N_BACK?
30- break;
31-
32- case LAYER_N_FRONT:
33- aLayers[0] = ITEM_GAL_LAYER( MOD_TEXT_FR_VISIBLE ); // how about SILKSCREEN_N_FRONT?
34+ case TEXT_is_REFERENCE:
35+ aLayers[0] = ITEM_GAL_LAYER( MOD_REFERENCES_VISIBLE );
36+ break;
37+
38+ case TEXT_is_VALUE:
39+ aLayers[0] = ITEM_GAL_LAYER( MOD_VALUES_VISIBLE );
40+ break;
41+
42+ default:
43+ switch( GetParent()->GetLayer() )
44+ {
45+ case LAYER_N_BACK:
46+ aLayers[0] = ITEM_GAL_LAYER( MOD_TEXT_BK_VISIBLE ); // how about SILKSCREEN_N_BACK?
47+ break;
48+
49+ case LAYER_N_FRONT:
50+ aLayers[0] = ITEM_GAL_LAYER( MOD_TEXT_FR_VISIBLE ); // how about SILKSCREEN_N_FRONT?
51+ break;
52+ }
53 break;
54 }
55- break;
56 }
57
58 aCount = 1;
59
60=== modified file 'pcbnew/ratsnest_data.cpp'
61--- pcbnew/ratsnest_data.cpp 2013-12-20 14:18:41 +0000
62+++ pcbnew/ratsnest_data.cpp 2014-02-03 07:59:14 +0000
63@@ -240,7 +240,7 @@
64
65 return;
66 }
67- else if( boardNodes.size() == 1 ) // This case is even simpler
68+ else if( boardNodes.size() <= 1 ) // This case is even simpler
69 {
70 m_rnEdges.reset( new std::vector<RN_EDGE_PTR>( 0 ) );
71