> Should we have a unit test? > Fixed.
> + std::shared_ptr<GLConfig> const& gl_config) > could just be a reference, we don't seem to take the shared_ptr. Fixed.
> > 94 + > unneeded addition?
This is to match the blank line at the top of the class declaration.
« Back to merge proposal
> Should we have a unit test?
>
Fixed.
> + std::shared_ ptr<GLConfig> const& gl_config)
> could just be a reference, we don't seem to take the shared_ptr.
Fixed.
>
> 94 +
> unneeded addition?
This is to match the blank line at the top of the class declaration.