Mir

Code review comment for lp:~cemil-azizoglu/mir/fix-lp1589632

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

> Should we have a unit test?
>
Fixed.

> + std::shared_ptr<GLConfig> const& gl_config)
> could just be a reference, we don't seem to take the shared_ptr.
Fixed.

>
> 94 +
> unneeded addition?

This is to match the blank line at the top of the class declaration.

« Back to merge proposal