Mir

Code review comment for lp:~cemil-azizoglu/mir/fix-1628794

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Haven't looked deeply enough to comment on the need for this (vs using shared_ptr).

In any case, we don't need the extra allocation for mp::Void. The following should work (but I haven't tested):

auto const protobuf_void = new mp::Void; // ...shudder...
server.allocate_buffers(&request, protobuf_void,...)

review: Needs Fixing

« Back to merge proposal