Mir

Code review comment for lp:~cemil-azizoglu/mir/fix-1628794

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This approach will probably fail (and it did when I tried it some months ago already). The requests complete asynchronously so can't share the same result object. Each call (not just each function) needs its own result object. Also I have further work on the way that uses the protobuf_void.error() values so will need to be able to get at them.

Clearly if the shared_ptr is still leaking then we've got a problem with the NewCallback itself getting leaked at the lower level, sometimes.

review: Needs Fixing

« Back to merge proposal