Merge lp:~cellsoftware/telegram-app/1582178 into lp:telegram-app

Proposed by Paz Chauhan
Status: Merged
Approved by: Jin
Approved revision: 214
Merged at revision: 215
Proposed branch: lp:~cellsoftware/telegram-app/1582178
Merge into: lp:telegram-app
Diff against target: 48 lines (+25/-6)
1 file modified
telegram/app/qml/AccountMessageList.qml (+25/-6)
To merge this branch: bzr merge lp:~cellsoftware/telegram-app/1582178
Reviewer Review Type Date Requested Status
Jin (community) Approve
Review via email: mp+298538@code.launchpad.net

Description of the change

onSelectedChanged introduced to sync the tapping of the item and the tapping of the check box in 'selection' mode

To post a comment you must log in.
Revision history for this message
Paz Chauhan (paz-chauhan) wrote :

When selecting an image to forward there have been 2 observations:

(1) Tapping the image or the check box in 'selection' mode will still preview the image
(2) On iOS the forwarded images appear in reverse order
(3) On Android the images initially appeared in reverse order, but subsequent tests resulted in them appearing in the correct order

Revision history for this message
Jin (jindallo) wrote :

Code looks great!
Thanks for this patch and I approve.

Verified pass.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'telegram/app/qml/AccountMessageList.qml'
2--- telegram/app/qml/AccountMessageList.qml 2016-05-17 07:43:03 +0000
3+++ telegram/app/qml/AccountMessageList.qml 2016-06-28 14:55:44 +0000
4@@ -294,19 +294,38 @@
5 }
6 }
7
8- onClicked: {
9- console.log("on item clicked");
10+ onSelectedChanged:{
11 if (mlist.isInSelectionMode) {
12- if (selected) {
13+ if (!selected)
14 mlist.deselectItem(message_item);
15- } else {
16+ else
17 mlist.selectItem(message_item);
18- }
19 }
20-
21 message_item.click();
22 }
23
24+ onClicked: {
25+ if (mlist.isInSelectionMode) {
26+ if (selected)
27+ selected = false;
28+ else
29+ selected = true;
30+ }
31+ }
32+
33+// onClicked: {
34+// console.log("on item clicked");
35+// if (mlist.isInSelectionMode) {
36+// if (selected) {
37+// mlist.deselectItem(message_item)
38+// } else {
39+// mlist.selectItem(message_item)
40+// }
41+// }
42+
43+// message_item.click();
44+// }
45+
46 onPreviewRequest: {
47 console.log("onOpenMedia");
48 var properties;

Subscribers

People subscribed via source and target branches

to status/vote changes: