Merge lp:~cellsoftware/telegram-app/1580050-fix into lp:telegram-app

[Ash]

Fixes an issue where user would still see a blank screen whilst on the conversation details when session is terminated.

[lp:~cellsoftware/telegram-app/1580050-fix]

213. By Ash on 2016-06-23

Removed unnecessary console log

[Jin (jindallo)]

Looks good to me,
I will approve if verified locally.

[Jin (jindallo)]

Still show a blank in testing,
the log here:
    ...
    [20160624 11:53:52.949 CST qml: auth error: SESSION_REVOKED
    [20160624 11:53:53.035 CST error_slt 401 "SESSION_REVOKED" "messagesGetDialogs"
    [20160624 11:53:53.105 CST qml: auth error: SESSION_REVOKED
    [20160624 11:53:53.106 CST error_slt 401 "SESSION_REVOKED" "updatesGetState"
    ...

And some inline comment made by me,
could please take a look,
thanks.

review: Needs Fixing

[Jin (jindallo)]

// inline comment added

[Ash (ashley-richards)]

> Still show a blank in testing,
> the log here:
> ...
> [20160624 11:53:52.949 CST qml: auth error: SESSION_REVOKED
> [20160624 11:53:53.035 CST error_slt 401 "SESSION_REVOKED"
> "messagesGetDialogs"
> [20160624 11:53:53.105 CST qml: auth error: SESSION_REVOKED
> [20160624 11:53:53.106 CST error_slt 401 "SESSION_REVOKED"
> "updatesGetState"
> ...
>
> And some inline comment made by me,
> could please take a look,
> thanks.

Thanks Jin. What were your steps to reproduce?

[Jin (jindallo)]

Hello Ash,

The same steps,
I keep in the AccountPage (main view),
then use the web-version Telegram to terminate all sessions,
as expected the app. need to jump back to IntroPage since you call showIntro() below,
but it doesn't, just a blank shown there.

[lp:~cellsoftware/telegram-app/1580050-fix]

214. By Ash on 2016-06-28

WIP - Updated potencial fix for the blank screen

215. By Ash on 2016-06-28

WIP - Put IF statement back in

216. By Paz Chauhan on 2016-06-29

.po and .pot files reverted

[Jin (jindallo)]

The code looks good,
I will approve after verified pass locally.

[Jin (jindallo)]

Issue resolved,
and verified pass from my local,
I approve.

review: Approve

=== modified file 'telegram/app/qml/AccountListItem.qml'
--- telegram/app/qml/AccountListItem.qml	2016-06-24 09:56:08 +0000
+++ telegram/app/qml/AccountListItem.qml	2016-06-29 15:28:21 +0000
@@ -71,11 +71,15 @@
         autoCleanUpMessages: true
         autoAcceptEncrypted: true
 
-        onErrorSignal: {
+        onErrorSignal:{
             if (errorText === "SESSION_REVOKED" || errorText === "AUTH_KEY_UNREGISTERED") {
-                profiles.remove(telegram.phoneNumber);
                 telegram.logoutRequest = true;
                 telegram.authLogout();
+
+                profiles.remove(telegram.phoneNumber);
+                if (profiles.count === 0)
+                    pageStack.primaryPageSource = null;
+
                 showIntro();
             }