Merge lp:~cellsoftware/telegram-app/1552201 into lp:telegram-app

Proposed by Ash
Status: Merged
Approved by: Jin
Approved revision: 184
Merged at revision: 191
Proposed branch: lp:~cellsoftware/telegram-app/1552201
Merge into: lp:telegram-app
Diff against target: 52 lines (+15/-9)
2 files modified
telegram/app/qml/AccountMessageList.qml (+14/-8)
telegram/app/qml/components/MessagesListItem.qml (+1/-1)
To merge this branch: bzr merge lp:~cellsoftware/telegram-app/1552201
Reviewer Review Type Date Requested Status
Jin (community) Approve
Review via email: mp+294607@code.launchpad.net

Description of the change

Fixes 'read' status on secret chat.

To post a comment you must log in.
Revision history for this message
Jin (jindallo) wrote :

Code looks good to me,
I will approve after get it verified locally.

Revision history for this message
Jin (jindallo) wrote :

Verified pass,
I approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'telegram/app/qml/AccountMessageList.qml'
2--- telegram/app/qml/AccountMessageList.qml 2016-03-16 15:13:26 +0000
3+++ telegram/app/qml/AccountMessageList.qml 2016-05-13 08:54:08 +0000
4@@ -101,13 +101,20 @@
5 property Document doc
6 }
7
8- // Timer {
9- // id: refresh_timer
10- // repeat: true
11- // interval: 10000
12- // onTriggered: messages_model.refresh()
13- // Component.onCompleted: start()
14- // }
15+ //Timer refreshes MessagesModel to check if message(s) have been read or not
16+ Timer {
17+ id: refresh_timer
18+ repeat: true
19+ interval: 1500
20+ onTriggered:{
21+ messages_model.refresh()
22+ }
23+ Component.onCompleted:{
24+ if (!isChat){
25+ start()
26+ }
27+ }
28+ }
29
30 Image {
31 anchors.fill: parent
32@@ -338,7 +345,6 @@
33 maximumFlickVelocity = maximumFlickVelocity * scaleFactor;
34 flickDeceleration = flickDeceleration * scaleFactor;
35 }
36-
37 }
38
39 MouseArea {
40
41=== modified file 'telegram/app/qml/components/MessagesListItem.qml'
42--- telegram/app/qml/components/MessagesListItem.qml 2016-04-21 15:45:32 +0000
43+++ telegram/app/qml/components/MessagesListItem.qml 2016-05-13 08:54:08 +0000
44@@ -285,7 +285,7 @@
45 right: parent.right
46 }
47
48- message: message_item.message
49+ message: message_item.message;
50 hasMedia: message_item.hasMedia
51
52 property int deltaY: message_wrapper.timeFitsSide ? -units.dp(4) : height

Subscribers

People subscribed via source and target branches

to status/vote changes: