Merge lp:~celebdor/charm-helpers/liberty into lp:charm-helpers

Proposed by Antoni Segura Puimedon on 2016-01-22
Status: Merged
Merged at revision: 523
Proposed branch: lp:~celebdor/charm-helpers/liberty
Merge into: lp:charm-helpers
Diff against target: 40 lines (+19/-0)
2 files modified
charmhelpers/contrib/openstack/neutron.py (+8/-0)
tests/contrib/openstack/test_neutron_utils.py (+11/-0)
To merge this branch: bzr merge lp:~celebdor/charm-helpers/liberty
Reviewer Review Type Date Requested Status
James Page 2016-01-22 Pending
Review via email: mp+283707@code.launchpad.net

Description of the Change

To post a comment you must log in.
lp:~celebdor/charm-helpers/liberty updated on 2016-01-23
524. By Antoni Segura Puimedon <email address hidden> on 2016-01-23

Add test for the midonet kilo and liberty special behavior

525. By Antoni Segura Puimedon <email address hidden> on 2016-01-23

fix lack of midonet-origin for liberty specific behavior

James Page (james-page) :
lp:~celebdor/charm-helpers/liberty updated on 2016-01-25
526. By Antoni Segura Puimedon <email address hidden> on 2016-01-25

fix code for when midonet-origin is not set

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmhelpers/contrib/openstack/neutron.py'
2--- charmhelpers/contrib/openstack/neutron.py 2016-01-18 11:28:34 +0000
3+++ charmhelpers/contrib/openstack/neutron.py 2016-01-25 15:01:02 +0000
4@@ -233,6 +233,14 @@
5 'neutron-plugin-ml2']
6 # NOTE: patch in vmware renames nvp->nsx for icehouse onwards
7 plugins['nvp'] = plugins['nsx']
8+ if release >= 'kilo':
9+ plugins['midonet']['driver'] = (
10+ 'neutron.plugins.midonet.plugin.MidonetPluginV2')
11+ if release >= 'liberty':
12+ midonet_origin = config('midonet-origin')
13+ if midonet_origin is not None and midonet_origin[4:5] == '1':
14+ plugins['midonet']['driver'] = (
15+ 'midonet.neutron.plugin_v1.MidonetPluginV2')
16 return plugins
17
18
19
20=== modified file 'tests/contrib/openstack/test_neutron_utils.py'
21--- tests/contrib/openstack/test_neutron_utils.py 2016-01-18 11:28:34 +0000
22+++ tests/contrib/openstack/test_neutron_utils.py 2016-01-25 15:01:02 +0000
23@@ -80,6 +80,17 @@
24 self.assertEquals(plugins['nvp']['services'], [])
25 self.assertEquals(plugins['nsx'], plugins['nvp'])
26
27+ self.os_release.return_value = 'kilo'
28+ plugins = neutron.neutron_plugins()
29+ self.assertEquals(plugins['midonet']['driver'],
30+ 'neutron.plugins.midonet.plugin.MidonetPluginV2')
31+
32+ self.os_release.return_value = 'liberty'
33+ self.config.return_value = 'mem-1.9'
34+ plugins = neutron.neutron_plugins()
35+ self.assertEquals(plugins['midonet']['driver'],
36+ 'midonet.neutron.plugin_v1.MidonetPluginV2')
37+
38 @patch.object(neutron, 'network_manager')
39 def test_neutron_plugin_attribute_quantum(self, _network_manager):
40 self.config.return_value = 'foo'

Subscribers

People subscribed via source and target branches