Code review comment for lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM : the connection must be closed.


I cannot find by reading the code a case where this branch is executed (i.e. a logical path in which we get len(self._connections) >= self._maxconn so I'm wondering if we are not improving dead code here.

Do you have a scenario at hand?

review: Approve (code review, sometest without being able to exercise that code)

« Back to merge proposal