Merge lp:~ce-infrastructure/capomastro/charm-sso into lp:~ubuntuone-hackers/capomastro/charm
Proposed by
Caio Begotti
Status: | Merged |
---|---|
Merged at revision: | 55 |
Proposed branch: | lp:~ce-infrastructure/capomastro/charm-sso |
Merge into: | lp:~ubuntuone-hackers/capomastro/charm |
Diff against target: |
38 lines (+20/-1) 1 file modified
templates/http_virtualhost.tmpl (+20/-1) |
To merge this branch: | bzr merge lp:~ce-infrastructure/capomastro/charm-sso |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Review via email: mp+242104@code.launchpad.net |
Description of the change
I have worked out a few changes to the original OpenID charm available via jujucharms.com and this merge request uses it to have finally SSO support when deploying Capomastro. No need to manually log into the Apache box to create the store directory and authorization lists. When this is more mature (i.e. reviewed by IS) perhaps we could keep the OpenID charm inside Capomastro's repository to reduce bus factor even further.
To post a comment you must log in.
Ohh, I see now the "don't proxypass /openid" to avoid the loop.
Other than that this looks very close to the template we've been using so +1 from me. Thanks!