Merge lp:~ce-infrastructure/capomastro/capomastro-logrotation-1391718 into lp:capomastro

Proposed by Caio Begotti
Status: Merged
Approved by: Daniel Manrique
Approved revision: 144
Merged at revision: 143
Proposed branch: lp:~ce-infrastructure/capomastro/capomastro-logrotation-1391718
Merge into: lp:capomastro
Diff against target: 29 lines (+17/-0)
2 files modified
debian/capomastro.logrotate (+11/-0)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp:~ce-infrastructure/capomastro/capomastro-logrotation-1391718
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+243018@code.launchpad.net

Description of the change

Fix for https://bugs.launchpad.net/capomastro/+bug/1391718 because we had at least 500mb being used for debug logs on Canonistack and this will make IS less concerned about Capomastro in production I guess.

To post a comment you must log in.
Revision history for this message
Caio Begotti (caio1982) wrote :

Once this is merged I'll release another package to the PPA.

Revision history for this message
Caio Begotti (caio1982) :
Revision history for this message
Daniel Manrique (roadmr) wrote :

Great! I think a couple of settings are redundant, see below for comments.

review: Needs Information
Revision history for this message
Caio Begotti (caio1982) :
144. By Caio Begotti

fix the code review, specially the maxsize option, which is the one i wanted in the first place

Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks better now, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/capomastro.logrotate'
2--- debian/capomastro.logrotate 1970-01-01 00:00:00 +0000
3+++ debian/capomastro.logrotate 2014-11-27 15:37:46 +0000
4@@ -0,0 +1,11 @@
5+/var/log/capomastro/celery.log {
6+ rotate 7
7+ maxsize 100M
8+ daily
9+ compress
10+ delaycompress
11+ missingok
12+ notifempty
13+ su capomastro capomastro
14+ create 640 capomastro capomastro
15+}
16
17=== modified file 'debian/changelog'
18--- debian/changelog 2014-11-21 17:03:00 +0000
19+++ debian/changelog 2014-11-27 15:37:46 +0000
20@@ -1,3 +1,9 @@
21+capomastro (20141127) trusty; urgency=high
22+
23+ * Includes a log rotation setup now.
24+
25+ -- Caio Begotti <caio.begotti@canonical.com> Thu, 27 Nov 2014 08:46:35 -0200
26+
27 capomastro (20141121) trusty; urgency=high
28
29 * Provides a better initscript to make IS happier.

Subscribers

People subscribed via source and target branches