Merge lp:~ce-infrastructure/capomastro/capomastro-django-logs into lp:capomastro

[Caio Begotti]

Sheila, I'm asking you specifically to review it as I stole this setting from Poke and I think you know Django logging better than I do :-) in fact I just wanted to be on the safe side so we don't loose any Dajngo traces even though the log won't be too verbose at first.

[Sheila Miguez (codersquid)]

It looks good to me.

I should borrow from you and remove the AdminEmailHandler in my loggers since I'm not doing anything with that yet.

review: Approve

[Daniel Manrique (roadmr)]

The attempt to merge lp:~ce-infrastructure/capomastro/capomastro-django-logs into lp:capomastro failed. Below is the output from the failed tests.

[trusty] starting container
[trusty] (timing) 0.06user 0.00system 0:05.20elapsed 1%CPU (0avgtext+0avgdata 7864maxresident)k
[trusty] (timing) 0inputs+32outputs (0major+6071minor)pagefaults 0swaps
[trusty] provisioning container
[trusty] (timing) 21.26user 5.10system 0:36.53elapsed 72%CPU (0avgtext+0avgdata 51708maxresident)k
[trusty] (timing) 0inputs+72outputs (0major+950632minor)pagefaults 0swaps
[trusty-testing] Starting tests...
[trusty-testing] : FAIL
[trusty-testing] stdout: http://paste.ubuntu.com/9479665/
[trusty-testing] stderr: http://paste.ubuntu.com/9479666/
[trusty-testing] (timing) Command exited with non-zero status 1
[trusty-testing] (timing) 24.78user 5.40system 3:32.51elapsed 14%CPU (0avgtext+0avgdata 31148maxresident)k
[trusty-testing] (timing) 0inputs+208992outputs (0major+1035842minor)pagefaults 0swaps
[trusty-testing] Destroying container

trusty-testing doesn't exist

[Daniel Manrique (roadmr)]

Ohnoes, tarmac is un happy because when running the tests it can't touch the required file (directory doesn't exist). Perhaps the configuration you wanted applies at all times, and we won't want it to if we're running in testing mode? and of course, in testing the given directory doesn't exist. Am I correct in assuming the capomastro package will create that dir?

[lp:~ce-infrastructure/capomastro/capomastro-django-logs]

155. By Caio Begotti on 2014-12-11

fix the tarmac verification if the file really exists

=== modified file 'capomastro/settings.py'
--- capomastro/settings.py	2014-11-03 19:06:32 +0000
+++ capomastro/settings.py	2014-12-11 20:11:47 +0000
@@ -113,6 +113,61 @@
 
 SITE_ID = 1
 
+# Logging Configuration
+# See http://docs.djangoproject.com/en/dev/topics/logging for
+# more details on how to customize your logging configuration.
+LOGGING = {
+    'version': 1,
+    'disable_existing_loggers': False,
+    'formatters': {
+        'verbose': {
+            'format': '%(asctime)s | '
+                      '%(levelname)s | '
+                      '%(name)s | '
+                      '%(module)s | '
+                      '%(funcName)s | '
+                      '%(process)d | '
+                      '%(thread)d | '
+                      '%(message)s',
+            'datefmt': '%Y%m%d-%H:%M:%S',
+        },
+        'simple': {
+            'format': '%(levelname)s %(message)s'
+        },
+    },
+    'filters': {
+        'require_debug_false': {
+            '()': 'django.utils.log.RequireDebugFalse'
+        }
+    },
+    'handlers': {
+        'mail_admins': {
+            'level': 'ERROR',
+            'filters': ['require_debug_false'],
+            'class': 'django.utils.log.AdminEmailHandler',
+            'formatter': 'verbose'
+        },
+        'logfile': {
+            'level': 'DEBUG',
+            'class': 'logging.handlers.TimedRotatingFileHandler',
+            'formatter': 'verbose',
+            'filename': '/var/log/capomastro/django.log',
+            'when': 'midnight',
+            'utc': True,
+        },
+    },
+    'loggers': {
+        'django.request': {
+            'handlers': ['logfile'],
+            'level': 'ERROR',
+        },
+        'django.db.backends': {
+            'handlers': ['logfile'],
+            'level': 'ERROR',
+        },
+    },
+}
+
 try:
     from key_settings import *  # noqa
 except ImportError, e:

=== modified file 'debian/capomastro.logrotate'
--- debian/capomastro.logrotate	2014-11-27 15:37:33 +0000
+++ debian/capomastro.logrotate	2014-12-11 20:11:47 +0000
@@ -1,4 +1,4 @@
-/var/log/capomastro/celery.log {
+/var/log/capomastro/celery.log /var/log/capomastro/django.log {
   rotate 7
   maxsize 100M
   daily

=== modified file 'testing/provision-testing-environment'
--- testing/provision-testing-environment	2014-11-12 09:27:27 +0000
+++ testing/provision-testing-environment	2014-12-11 20:11:47 +0000
@@ -4,6 +4,12 @@
 
 set -e
 
+# Makes Tarmac happy about the new LOGGING setup
+# that would only be created by the debian package
+logdir=/var/log/capomastro
+mkdir -p ${logdir}
+touch ${logdir}/django.log
+
 # Update to have the latest packages, this is needed because the image comes
 # with an old (and no longer working) apt cache and links to many packages no
 # longer work. This is also needed if the step above actually added any PPAs.