~cdwertmann/cumulus-frr/+git/trunk:rc/8.4.1

Last commit made on 2022-11-18
Get this branch:
git clone -b rc/8.4.1 https://git.launchpad.net/~cdwertmann/cumulus-frr/+git/trunk

Branch merges

Branch information

Name:
rc/8.4.1
Repository:
lp:~cdwertmann/cumulus-frr/+git/trunk

Recent commits

70151e2... by Jafar Al-Gharaibeh

FRR Release 8.4.1

- zebra: reuse netinet/if_ether.h to avoid redefinition of struct ethhdr
- zebra: fix build without AF_MPLS
- ospfd: get route-map name for default-information originate
- ospfd: allow unnumbered and numbered addresses to co-exist better
- ospfd: prevent from crashing when processing external lsa
- bgpd: fix "storing the address of local variable"
- bgpd: rpki was decrementing the node lock one time too many
- bgpd: do not send Deconfig/Shutdown message when restarting
- pimd: convert zlog_warn to debug

Signed-off-by: Jafar Al-Gharaibeh <email address hidden>

6b72cc2... by Donatas Abraitis <email address hidden>

Merge pull request #12332 from FRRouting/mergify/bp/stable/8.4/pr-12309

bgpd: fix invalid ipv4-vpn nexthop for IPv6 peer (backport #12309)

8dff1be... by Ryoga Saito <email address hidden>

bgpd: fix invalid ipv4-vpn nexthop for IPv6 peer

Given that two routers are connected each other and they have IPv6
addresses and they establish BGP peer with extended-nexthop capability
and one router tries to advertise locally-generated IPv4-VPN routes to
other router.

In this situation, bgpd on the router that tries to advertise IPv4-VPN
routes will be crashed with "invalid MP nexthop length (AFI IP6)".

This issue is happened because MP_REACH_NLRI path attribute is not
generated correctly when ipv4-vpn routes are advertised to IPv6 peer.
When IPv4 routes are leaked from VRF RIB, the nexthop of these routes
are also IPv4 address (0.0.0.0/0 or specific addresses). However,
bgp_packet_mpattr_start only covers the case of IPv6 nexthop (for IPv6
peer).

ipv4-unicast routes were not affected by this issue because the case of
IPv4 nexthop is covered in `else` block.

Signed-off-by: Ryoga Saito <email address hidden>
(cherry picked from commit 63e7ddb509435d9e178cf51a9a288273fb91bf7e)

daa2126... by Ryoga Saito <email address hidden>

tests: Add topotest for l3vpn over ipv6 peer

To check the effect of the next patch, I added topotest.

Signed-off-by: Ryoga Saito <email address hidden>
(cherry picked from commit 3db8aa8750d1be675f6df1ed765afeb101b6402b)

43b7aec... by Donatas Abraitis <email address hidden>

Merge pull request #12331 from FRRouting/mergify/bp/stable/8.4/pr-12302

isisd: fix area NULL pointer in isis_route_update (backport #12302)

935c3f3... by Donatas Abraitis <email address hidden>

Merge pull request #12330 from FRRouting/mergify/bp/stable/8.4/pr-12312

bgpd: authorise to select bgp self peer prefix on rr case (backport #12312)

7a07501... by Louis Scalbert <louis.scalbert@6wind.com>

isisd: fix area NULL pointer in isis_route_update

Fix the case area is NULL.

Fixes: acc0029779 ("isisd: fix potential access to NULL pointer in isis_route_update")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
(cherry picked from commit 41c2bf853f072008330a929480bf235ac840212a)

56dd706... by Philippe Guibert

bgpd: authorise to select bgp self peer prefix on rr case

This commit addresses an issue that happens when using bgp
peering with a rr client, with a received prefix which is the
local ip address of the bgp session.

When using bgp ipv4 unicast session, the local prefix is
received by a peer, and finds out that the proposed prefix
and its next-hop are the same. To avoid a route loop locally,
no nexthop entry is referenced for that prefix, and the route
will not be selected.

When the received peer is a route reflector, the prefix has
to be selected, even if the route can not be installed locally.

Fixes: ("fb8ae704615c") bgpd: prevent routes loop through itself

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
(cherry picked from commit f874552557cf2577ae91b297f422e307084f22d3)

23f40f2... by Donatas Abraitis <email address hidden>

Merge pull request #12320 from FRRouting/mergify/bp/stable/8.4/pr-12307

tools: remove backslash from declare check regex (backport #12307)

47c5955... by Donatas Abraitis <email address hidden>

Merge pull request #12319 from FRRouting/mergify/bp/stable/8.4/pr-12315

Dplane sorry (backport #12315)